← Back to team overview

kernel-packages team mailing list archive

[Bug 1514861] Re: mlx5 EN driver wrongly enables sets VLAN filtering under promiscuous mode

 

Talat - I assume you have had positive test results with your backport
patch ?

** Also affects: linux (Ubuntu Xenial)
   Importance: Undecided
       Status: Incomplete

** Also affects: linux (Ubuntu Wily)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Xenial)
       Status: Incomplete => Fix Released

** Changed in: linux (Ubuntu Wily)
       Status: New => In Progress

** Changed in: linux (Ubuntu Wily)
     Assignee: (unassigned) => Tim Gardner (timg-tpi)

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1514861

Title:
   mlx5 EN driver wrongly enables sets VLAN filtering under promiscuous
  mode

Status in linux package in Ubuntu:
  Fix Released
Status in linux source package in Wily:
  In Progress
Status in linux source package in Xenial:
  Fix Released

Bug description:
  Description of problem: The mlx5 Ethernet driver doesn't allow packets
  marked with all possible VLAN tags to be accepted under promiscuous
  mode. This is wrong and disallows Open-Stack to properly function in
  Para-Virtual configuration.

  
  How reproducible: 

   just put the NIC to promiscuous mode and send packet from another
  node tagged any vlan which was not previously configured on the NIC
  vlan filter, it will not be accepted.

  
  Actual results:
  ARP packets sent on vlan 52 packets are dropped 

  Expected results:
  packets should received 

  Host info:
  #uname -a
  Linux dev-h-vrt-006 4.2.0-16-generic #19-Ubuntu SMP Thu Oct 8 15:35:06 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

  #lsb_release -a
  No LSB modules are available.
  Distributor ID: Ubuntu
  Description:    Ubuntu 15.10
  Release:        15.10
  Codename:       wily

  
  The following upstream commit fix it:

  commit c07543431e9f3d126d083808efa0e76461d8833b
  Author: Achiad Shochat <achiad@xxxxxxxxxxxx>
  Date:   Thu Oct 8 15:26:18 2015 +0300

      net/mlx5e: Disable VLAN filter in promiscuous mode

      When the device was set to promiscuous mode, we didn't disable
      VLAN filtering, which is wrong behaviour, fix that.

      Now when the device is set to promiscuous mode RX packets
      sent over any VLAN (or no VLAN tag at all) will be accepted.

      Signed-off-by: Achiad Shochat <achiad@xxxxxxxxxxxx>
      Signed-off-by: Or Gerlitz <ogerlitz@xxxxxxxxxxxx>
      Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

  I backported it to Ubuntu 15.10 (please see the attached patch). This
  issue need to be fix also in Ubuntu 14.04.4 not only 15.10.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1514861/+subscriptions


References