kernel-packages team mailing list archive

[Daniel van Vugt <daniel.van.vugt@xxxxxxxxxxxxx>]

Is this critical? I'm not familiar with prompt sessions, but on my
xenial machine I find Unity8 still works even when this bug is present.
Does it really affect us in production right now?

** Changed in: mir
   Importance: Critical => High

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1540731

Title:
  SocketMessenger::update_session_creds() fails to get client PID,
  causing "[ FAILED ]
  PromptSessionClientAPI.client_pid_is_associated_with_session"

Status in GLibC:
  New
Status in Mir:
  Confirmed
Status in linux package in Ubuntu:
  Confirmed

Bug description:
  Since updating to the 4.4.0-2 kernel recvmsg() fails SCM_CREDENTIALS
  request with EOPNOTSUPP.

  This manifests as a test failure in Mir:

      [ RUN      ] PromptSessionClientAPI.client_pid_is_associated_with_session
      unknown file: Failure

  Test case:

  #include <gtest/gtest.h>
  #include <gmock/gmock.h>
  #include <sys/socket.h>
  #include <sys/stat.h>

  TEST(IsItBroken, recvmsg)
  {
      using namespace testing;

      enum { server, client, size };
      int socket_fd[size];
      int const opt = 1;

      ASSERT_THAT(socketpair(AF_LOCAL, SOCK_STREAM, 0, socket_fd),
  Eq(0));

      auto const msg = "A random message";
      send(socket_fd[client], msg, sizeof msg, MSG_DONTWAIT | MSG_NOSIGNAL);

      ASSERT_THAT(setsockopt(socket_fd[server], SOL_SOCKET, SO_PASSCRED,
  &opt, sizeof(opt)), Ne(-1));

      union {
          struct cmsghdr cmh;
          char   control[CMSG_SPACE(sizeof(ucred))];
      } control_un;

      control_un.cmh.cmsg_len = CMSG_LEN(sizeof(ucred));
      control_un.cmh.cmsg_level = SOL_SOCKET;
      control_un.cmh.cmsg_type = SCM_CREDENTIALS;

      msghdr msgh;
      msgh.msg_name = nullptr;
      msgh.msg_namelen = 0;
      msgh.msg_iov = nullptr;
      msgh.msg_iovlen = 0;
      msgh.msg_control = control_un.control;
      msgh.msg_controllen = sizeof(control_un.control);

      errno = 0;

      EXPECT_THAT(recvmsg(socket_fd[server], &msgh, MSG_PEEK), Ne(-1))
          << "Error: " << strerror(errno);

      for (auto socket : socket_fd) close(socket);
  }

To manage notifications about this bug go to:
https://bugs.launchpad.net/glibc/+bug/1540731/+subscriptions