← Back to team overview

kernel-packages team mailing list archive

[Bug 1567091] [NEW] fixes for thunderx nic in multiqueue mode

 

Public bug reported:

There are a number of bug fixes in the thunderx nic driver for multi-
queue support that have landed upstream since 4.4:

commit 4fbe366ce304d836d53685c1dd26865dc1fea66c
Merge: 1eea84b ad2eceb
Author: David S. Miller <davem@xxxxxxxxxxxxx>
Date:   Wed Feb 17 22:24:57 2016 -0500

    Merge branch 'thunderx-fixes'
    
    Sunil Goutham says:
    
    ====================
    net: thunderx: Miscellaneous fixes
    
    This patch series fixes couple of issues w.r.t multiqset mode
    and receive packet statastics.
    ====================
    
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

commit ad2ecebd67d8a80fe5412d11df375a5ed2db7cd1
Author: Sunil Goutham <sgoutham@xxxxxxxxxx>
Date:   Tue Feb 16 16:29:51 2016 +0530

    net: thunderx: Fix receive packet stats
    
    Counting rx packets for every CQE_RX in CQ irq handler is incorrect.
    Synchronization is missing when multiple queues are receiving packets
    simultaneously. Like transmit packet stats use HW stats here.
    
    Also removed unused 'cqe_type' parameter in nicvf_rcv_pkt_handler().
    
    Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

commit 8d210d54c5250c52b69266f299e64fe8356f9453
Author: Sunil Goutham <sgoutham@xxxxxxxxxx>
Date:   Tue Feb 16 16:29:50 2016 +0530

    net: thunderx: Fix for HW TSO not enabled for secondary qsets
    
    For secondary Qsets 'hw_tso' is not getting set as probe() returns
    much earlier. Fixed it by moving silicon revision check.
    
    Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

commit 6a9bab79bb79bd9b2eda16f0aba1b4c43f677be9
Author: Sunil Goutham <sgoutham@xxxxxxxxxx>
Date:   Tue Feb 16 16:29:49 2016 +0530

    net: thunderx: Fix for multiqset not configured upon interface toggle
    
    When a interface is assigned morethan 8 queues and the logical interface
    is toggled i.e down & up, additional queues or qsets are not initialized
    as secondary qset count is being set to zero while tearing down.
    
    Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

** Affects: linux (Ubuntu)
     Importance: High
     Assignee: dann frazier (dannf)
         Status: In Progress

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1567091

Title:
  fixes for thunderx nic in multiqueue mode

Status in linux package in Ubuntu:
  In Progress

Bug description:
  There are a number of bug fixes in the thunderx nic driver for multi-
  queue support that have landed upstream since 4.4:

  commit 4fbe366ce304d836d53685c1dd26865dc1fea66c
  Merge: 1eea84b ad2eceb
  Author: David S. Miller <davem@xxxxxxxxxxxxx>
  Date:   Wed Feb 17 22:24:57 2016 -0500

      Merge branch 'thunderx-fixes'
      
      Sunil Goutham says:
      
      ====================
      net: thunderx: Miscellaneous fixes
      
      This patch series fixes couple of issues w.r.t multiqset mode
      and receive packet statastics.
      ====================
      
      Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

  commit ad2ecebd67d8a80fe5412d11df375a5ed2db7cd1
  Author: Sunil Goutham <sgoutham@xxxxxxxxxx>
  Date:   Tue Feb 16 16:29:51 2016 +0530

      net: thunderx: Fix receive packet stats
      
      Counting rx packets for every CQE_RX in CQ irq handler is incorrect.
      Synchronization is missing when multiple queues are receiving packets
      simultaneously. Like transmit packet stats use HW stats here.
      
      Also removed unused 'cqe_type' parameter in nicvf_rcv_pkt_handler().
      
      Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxx>
      Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

  commit 8d210d54c5250c52b69266f299e64fe8356f9453
  Author: Sunil Goutham <sgoutham@xxxxxxxxxx>
  Date:   Tue Feb 16 16:29:50 2016 +0530

      net: thunderx: Fix for HW TSO not enabled for secondary qsets
      
      For secondary Qsets 'hw_tso' is not getting set as probe() returns
      much earlier. Fixed it by moving silicon revision check.
      
      Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxx>
      Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

  commit 6a9bab79bb79bd9b2eda16f0aba1b4c43f677be9
  Author: Sunil Goutham <sgoutham@xxxxxxxxxx>
  Date:   Tue Feb 16 16:29:49 2016 +0530

      net: thunderx: Fix for multiqset not configured upon interface toggle
      
      When a interface is assigned morethan 8 queues and the logical interface
      is toggled i.e down & up, additional queues or qsets are not initialized
      as secondary qset count is being set to zero while tearing down.
      
      Signed-off-by: Sunil Goutham <sgoutham@xxxxxxxxxx>
      Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1567091/+subscriptions


Follow ups