← Back to team overview

kernel-packages team mailing list archive

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

 

Uploaded to yakkety:

grub2 (2.02~beta2-36ubuntu5) yakkety; urgency=medium

  * debian/patches/zpool_full_device_name.patch: Signal to zpool that
    it should emit full names of constituent devices.

** Changed in: grub2 (Ubuntu)
       Status: In Progress => Fix Released

** Description changed:

+ [Impact]
+ Installs over ZFS where a ZFS disk is expected to be used as a root device.
+ 
+ [Test case]
+ - Run update-grub on a system with a ZFS root filesystem.
+ 
+ [Regression Potential]
+ Installs relying on the current broken behavior to avoid listing other operating systems in grub menu may find that new entries are added.
+ 
+ ---
+ 
  update-grub runs /usr/sbin/grub-probe
  
  Without libzfslinux support compiled in, /usr/sbin/grub-probe runs
  ["zpool", "status", poolname] to find out ZFS info.
  
  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.
  
  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev/".
  
  It then tests the existence of the path name of the device. it fails.
  
  grub-probe then returns  something like
  
  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev/ata-
  ST31000333AS_99999999-part1'.
  
  The actual path is of course /dev/disk/by-id/ST31000333AS_99999999-part1
  
  It can prepend smarter than "/dev" or it can understand ZFS natively, to
  fix the problem.

** Also affects: grub2 (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Also affects: zfs-linux (Ubuntu Xenial)
   Importance: Undecided
       Status: New

** Changed in: grub2 (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: grub2 (Ubuntu Xenial)
     Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)

** Changed in: grub2 (Ubuntu Xenial)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

Status in grub:
  Unknown
Status in grub2 package in Ubuntu:
  Fix Released
Status in zfs-linux package in Ubuntu:
  Fix Released
Status in grub2 source package in Xenial:
  In Progress
Status in zfs-linux source package in Xenial:
  New

Bug description:
  [Impact]
  Installs over ZFS where a ZFS disk is expected to be used as a root device.

  [Test case]
  - Run update-grub on a system with a ZFS root filesystem.

  [Regression Potential]
  Installs relying on the current broken behavior to avoid listing other operating systems in grub menu may find that new entries are added.

  ---

  update-grub runs /usr/sbin/grub-probe

  Without libzfslinux support compiled in, /usr/sbin/grub-probe runs
  ["zpool", "status", poolname] to find out ZFS info.

  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.

  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev/".

  It then tests the existence of the path name of the device. it fails.

  grub-probe then returns  something like

  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev
  /ata-ST31000333AS_99999999-part1'.

  The actual path is of course /dev/disk/by-
  id/ST31000333AS_99999999-part1

  It can prepend smarter than "/dev" or it can understand ZFS natively,
  to fix the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions