← Back to team overview

kernel-packages team mailing list archive

[Bug 1527727] Re: grub-probe for zfs assumes all devices prefix with /dev, ignoring /dev/disk/...

 

This doesn't really depend on any extra steps -- I've just uploaded
grub2 and grub2-signed to xenial-proposed queue, so as soon as it's
reviewed by a member of the SRU team it will be available in proposed.

>From there, we'll need people to test this carefully to make sure
nothing is broken and that it's fulfilling its intended purposed (ie.
fixing the issue), after that we'll be able to make it available to the
general public in -updates.

** Also affects: grub2-signed (Ubuntu)
   Importance: Undecided
       Status: New

** Changed in: grub2-signed (Ubuntu)
       Status: New => Fix Released

** Changed in: grub2-signed (Ubuntu Xenial)
       Status: New => In Progress

** Changed in: grub2-signed (Ubuntu Xenial)
     Assignee: (unassigned) => Mathieu Trudel-Lapierre (cyphermox)

** Changed in: grub2-signed (Ubuntu Xenial)
   Importance: Undecided => Medium

** Changed in: grub2-signed (Ubuntu)
   Importance: Undecided => Medium

** Changed in: zfs-linux (Ubuntu Xenial)
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to zfs-linux in Ubuntu.
https://bugs.launchpad.net/bugs/1527727

Title:
  grub-probe for zfs assumes all devices prefix with /dev, ignoring
  /dev/disk/...

Status in grub:
  Unknown
Status in grub2 package in Ubuntu:
  Fix Released
Status in grub2-signed package in Ubuntu:
  Fix Released
Status in zfs-linux package in Ubuntu:
  Fix Released
Status in grub2 source package in Xenial:
  In Progress
Status in grub2-signed source package in Xenial:
  In Progress
Status in zfs-linux source package in Xenial:
  New

Bug description:
  [Impact]
  Installs over ZFS where a ZFS disk is expected to be used as a root device.

  [Test case]
  - Run update-grub on a system with a ZFS root filesystem.

  [Regression Potential]
  Installs relying on the current broken behavior to avoid listing other operating systems in grub menu may find that new entries are added.

  ---

  update-grub runs /usr/sbin/grub-probe

  Without libzfslinux support compiled in, /usr/sbin/grub-probe runs
  ["zpool", "status", poolname] to find out ZFS info.

  zpool responds with device names as used at (I think!) pool creation
  time. Often, this is /dev/disk/by-id/... names, without the path.

  grub-probe then parses the output, and takes the names of devices, and
  if they do not start with a "/", it prepends "/dev/".

  It then tests the existence of the path name of the device. it fails.

  grub-probe then returns  something like

  /usr/sbin/grub-probe: error: failed to get canonical path of `/dev
  /ata-ST31000333AS_99999999-part1'.

  The actual path is of course /dev/disk/by-
  id/ST31000333AS_99999999-part1

  It can prepend smarter than "/dev" or it can understand ZFS natively,
  to fix the problem.

To manage notifications about this bug go to:
https://bugs.launchpad.net/grub/+bug/1527727/+subscriptions