← Back to team overview

kernel-packages team mailing list archive

[Bug 1231931] Re: [PATCH] Enable internal mic on a Thinkpad machine

 

At Fri, 27 Sep 2013 13:10:25 +0200,
David Henningsson wrote:
> 
> From: Kailang <kailang@xxxxxxxxxxx>
> 
> More thorough testing showed that these verbs were necessary to
> improve quality of the internal mic. Patch originally from Realtek.
> 
> Cc: stable@xxxxxxxxxx (3.11)
> BugLink: https://bugs.launchpad.net/bugs/1231931
> Signed-off-by: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
> ---

Applied it now, but dropped the Cc to stable, since this can't be
applied cleanly without your former patch, which wasn't merged to
stable either.  If you'd like to move them to Cc, please inform the
all necessary upstream commit ids.


thanks,

Takashi

>  sound/pci/hda/patch_realtek.c |   13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index bc07d36..c4d54a9 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -3531,6 +3531,7 @@ enum {
>  	ALC269VB_FIXUP_ORDISSIMO_EVE2,
>  	ALC283_FIXUP_CHROME_BOOK,
>  	ALC282_FIXUP_ASUS_TX300,
> +	ALC283_FIXUP_INT_MIC,
>  };
>  
>  static const struct hda_fixup alc269_fixups[] = {
> @@ -3790,6 +3791,16 @@ static const struct hda_fixup alc269_fixups[] = {
>  		.type = HDA_FIXUP_FUNC,
>  		.v.func = alc282_fixup_asus_tx300,
>  	},
> +	[ALC283_FIXUP_INT_MIC] = {
> +		.type = HDA_FIXUP_VERBS,
> +		.v.verbs = (const struct hda_verb[]) {
> +			{0x20, AC_VERB_SET_COEF_INDEX, 0x1a},
> +			{0x20, AC_VERB_SET_PROC_COEF, 0x0011},
> +			{ }
> +		},
> +	.chained = true,
> +	.chain_id = ALC269_FIXUP_LIMIT_INT_MIC_BOOST
> +	},
>  };
>  
>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> @@ -3874,7 +3885,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x17aa, 0x2214, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x2215, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x5013, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> -	SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
> +	SND_PCI_QUIRK(0x17aa, 0x501a, "Thinkpad", ALC283_FIXUP_INT_MIC),
>  	SND_PCI_QUIRK(0x17aa, 0x5026, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x5109, "Thinkpad", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
>  	SND_PCI_QUIRK(0x17aa, 0x3bf8, "Quanta FL1", ALC269_FIXUP_PCM_44K),
> -- 
> 1.7.9.5
>

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1231931

Title:
  Enable internal mic on a Lenovo machine

Status in HWE Next Project:
  New
Status in “linux” package in Ubuntu:
  In Progress

Bug description:
  This bug is used for tracking purposes only, please do not triage.

To manage notifications about this bug go to:
https://bugs.launchpad.net/hwe-next/+bug/1231931/+subscriptions


Follow ups

References