← Back to team overview

kernel-packages team mailing list archive

[Bug 1227093] Re: [PATCH 2/2] ALSA: hda - Fix microphone for Sony VAIO Pro 13 (Haswell model)

 

On 10/10/2013 01:18 PM, Takashi Iwai wrote:
> At Thu, 10 Oct 2013 12:19:24 +0200,
> David Henningsson wrote:
>>
>> The external mic showed up with a precense detect of "always present",
>> essentially disabling the internal mic. Therefore turn off presence
>> detection for this pin.
>>
>> Note: The external mic seems not yet working, but an internal mic is
>> certainly better than no mic at all.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> BugLink: https://bugs.launchpad.net/bugs/1227093
>> Signed-off-by: David Henningsson <david.henningsson@xxxxxxxxxxxxx>
>> ---
>>  sound/pci/hda/patch_realtek.c |   11 +++++++++++
>>  1 file changed, 11 insertions(+)
>>
>> Note: when doing stable backports, the two lines ".chained = true" and
>> ".chain_id = ALC269_FIXUP_HEADSET_MIC" can be dropped.
> 
> Then better to split the patch to two, one just for disabling the dead
> ext mic pin, and another for adding the headset mic chain.  The former
> can go to stable while the latter goes to next together with the
> previous ALC269_FIXUP_HEADSET_MIC patch.

The problem here is somewhat lack of testers. We have only one person
with a headset (with alias Yuv) and that person reports that it does not
work. However, the problem might be with that person's headset so I
probably don't want to completely disable it, just remove its jack
detection. Especially as this would go to stable too.

But ok, I can make three patches, one for headset mic model, one for
sony, and a third that adds the connection between them.

> If adding a new fixup entry for stable, put to somewhere in the middle
> so that git cherry-pick would work.  Appending to the tail is
> problematic because of a few previous fixups aren't merged to stable,
> thus the new entry cannot be applied cleanly.

Hmm, but maybe middle will have same problem if we end up changing the
policy. Maybe random position will be better? Or put all stable first
and all non-stable last?

> 
> 
> thanks,
> 
> Takashi
> 
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 8cb3350..ec47681 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -3556,6 +3556,7 @@ enum {
>>  	ALC282_FIXUP_ASUS_TX300,
>>  	ALC283_FIXUP_INT_MIC,
>>  	ALC290_FIXUP_MONO_SPEAKERS,
>> +	ALC286_FIXUP_SONY_MIC_NO_PRESENCE,
>>  };
>>  
>>  static const struct hda_fixup alc269_fixups[] = {
>> @@ -3844,6 +3845,15 @@ static const struct hda_fixup alc269_fixups[] = {
>>  		.chained = true,
>>  		.chain_id = ALC269_FIXUP_DELL3_MIC_NO_PRESENCE,
>>  	},
>> +	[ALC286_FIXUP_SONY_MIC_NO_PRESENCE] = {
>> +		.type = HDA_FIXUP_PINS,
>> +		.v.pins = (const struct hda_pintbl[]) {
>> +			{ 0x18, 0x01a1913c }, /* use as headset mic, without its own jack detect */
>> +			{ }
>> +		},
>> +		.chained = true,
>> +		.chain_id = ALC269_FIXUP_HEADSET_MIC,
>> +	},
>>  };
>>  
>>  static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>> @@ -3908,6 +3918,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>>  	SND_PCI_QUIRK(0x1043, 0x8398, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
>>  	SND_PCI_QUIRK(0x1043, 0x83ce, "ASUS P1005", ALC269_FIXUP_STEREO_DMIC),
>>  	SND_PCI_QUIRK(0x1043, 0x8516, "ASUS X101CH", ALC269_FIXUP_ASUS_X101),
>> +	SND_PCI_QUIRK(0x104d, 0x90b6, "Sony VAIO Pro 13", ALC286_FIXUP_SONY_MIC_NO_PRESENCE),
>>  	SND_PCI_QUIRK(0x104d, 0x9073, "Sony VAIO", ALC275_FIXUP_SONY_VAIO_GPIO2),
>>  	SND_PCI_QUIRK(0x104d, 0x907b, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
>>  	SND_PCI_QUIRK(0x104d, 0x9084, "Sony VAIO", ALC275_FIXUP_SONY_HWEQ),
>> -- 
>> 1.7.9.5
>>
> 


-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1227093

Title:
  [haswell sony vaio pro] Internal microphone not working

Status in “linux” package in Ubuntu:
  Confirmed

Bug description:
  The internal microphone is not working on a new sony vaio pro with
  ubuntu 13.10 kernel. I've also tried latest mainline kernel v3.11-rc7.
  FYI, this laptop does not boot pre-saucy kernels.

  ProblemType: Bug
  DistroRelease: Ubuntu 13.10
  Package: linux-image-3.11.0-7-generic 3.11.0-7.14
  ProcVersionSignature: Ubuntu 3.11.0-7.14-generic 3.11.1
  Uname: Linux 3.11.0-7-generic x86_64
  ApportVersion: 2.12.1-0ubuntu4
  Architecture: amd64
  AudioDevicesInUse:
   USER        PID ACCESS COMMAND
   /dev/snd/controlC0:  francois   1951 F.... pulseaudio
   /dev/snd/controlC1:  francois   1951 F.... pulseaudio
  Date: Wed Sep 18 14:00:59 2013
  HibernationDevice: RESUME=UUID=336e37fb-47a2-406c-ad64-630659d38f70
  InstallationDate: Installed on 2013-07-30 (49 days ago)
  InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Alpha amd64 (20130729)
  MachineType: Sony Corporation SVP1321C5E
  MarkForUpload: True
  ProcFB: 0 inteldrmfb
  ProcKernelCmdLine: BOOT_IMAGE=/boot/vmlinuz-3.11.0-7-generic root=UUID=fe28f457-7a8a-4185-866b-115aded2e40c ro quiet splash vt.handoff=7
  RelatedPackageVersions:
   linux-restricted-modules-3.11.0-7-generic N/A
   linux-backports-modules-3.11.0-7-generic  N/A
   linux-firmware                            1.114
  SourcePackage: linux
  UpgradeStatus: No upgrade log present (probably fresh install)
  dmi.bios.date: 05/17/2013
  dmi.bios.vendor: American Megatrends Inc.
  dmi.bios.version: R0270V7
  dmi.board.asset.tag: N/A
  dmi.board.name: VAIO
  dmi.board.vendor: Sony Corporation
  dmi.board.version: N/A
  dmi.chassis.asset.tag: N/A
  dmi.chassis.type: 10
  dmi.chassis.vendor: Sony Corporation
  dmi.chassis.version: N/A
  dmi.modalias: dmi:bvnAmericanMegatrendsInc.:bvrR0270V7:bd05/17/2013:svnSonyCorporation:pnSVP1321C5E:pvrC60C1VKQ:rvnSonyCorporation:rnVAIO:rvrN/A:cvnSonyCorporation:ct10:cvrN/A:
  dmi.product.name: SVP1321C5E
  dmi.product.version: C60C1VKQ
  dmi.sys.vendor: Sony Corporation

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1227093/+subscriptions


Follow ups

References