kernel-packages team mailing list archive

[Tyler Hicks <tyhicks@xxxxxxxxxxxxx>]

This upstream commit, which is not in Lucid, removed the .ctl_name initializer
from netns_core_table:

  f8572d8 sysctl net: Remove unused binary sysctl code

Since Lucid's netns_core_table initializes .ctl_name, sysctl_check_table()
requires the .strategy field to be initialized. Other places using
proc_dointvec_minmax() for the .proc_handler seem to be using sysctl_intvec()
for the .strategy. I suppose the patch below would be the correct fix, but
would like someone from the kernel team to take over from here.

diff --git a/net/core/sysctl_net_core.c b/net/core/sysctl_net_core.c
index 4b1c570..8bc7541 100644
--- a/net/core/sysctl_net_core.c
+++ b/net/core/sysctl_net_core.c
@@ -132,6 +132,7 @@ static struct ctl_table netns_core_table[] = {
 		.extra1		= &zero,
 		.extra2		= &ushort_max,
 		.proc_handler	= proc_dointvec_minmax
+		.strategy	= &sysctl_intvec,
 	},
 	{ .ctl_name = 0 }
 };

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1326473

Title:
  No /proc/sys/net/ipv4/tcp_syncookies present with 2.6.32-61-generic
  #123 in -proposed

Status in “linux” package in Ubuntu:
  Incomplete

Bug description:
  The following security test failure is seen with the Platform QA
  Regression Testing task with 2.6.32-61-generic #123 kernel.

  06/04 15:06:05 ERROR|base_utils:0114| [stderr] 
  06/04 15:06:05 ERROR|base_utils:0114| [stderr] ======================================================================
  06/04 15:06:05 ERROR|base_utils:0114| [stderr] FAIL: SYN cookies is enabled
  06/04 15:06:05 ERROR|base_utils:0114| [stderr] ----------------------------------------------------------------------
  06/04 15:06:05 ERROR|base_utils:0114| [stderr] Traceback (most recent call last):
  06/04 15:06:05 ERROR|base_utils:0114| [stderr]   File "./test-kernel-security.py", line 359, in test_033_syn_cookies
  06/04 15:06:05 ERROR|base_utils:0114| [stderr]     self._test_sysctl_value('net/ipv4/tcp_syncookies', expected)
  06/04 15:06:05 ERROR|base_utils:0114| [stderr]   File "/home/ubuntu/autotest/client/tmp/ubuntu_qrt_kernel_security/src/scripts/testlib.py", line 1050, in _test_sysctl_value
  06/04 15:06:05 ERROR|base_utils:0114| [stderr]     self.assertEquals(exists, os.path.exists(sysctl), sysctl)
  06/04 15:06:05 ERROR|base_utils:0114| [stderr] AssertionError: /proc/sys/net/ipv4/tcp_syncookies

  Please see https://jenkins.qa.ubuntu.com/view/All/job/sru_kernel-
  lucid-
  generic_i386-amd_64-mga_g200ew/47/testReport/junit/autotest/ubuntu_qrt_kernel_security/test_kernel_security_py/
  for detailed logs.

  This can also be seen linux-ec2: 2.6.32-365.78 too.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1326473/+subscriptions