← Back to team overview

kernel-packages team mailing list archive

Re: [Bug 1328295] Re: [serial] use hw flow control if supported

 

On Fri, Jun 13, 2014 at 3:28 PM, Joseph Salisbury
<joseph.salisbury@xxxxxxxxxxxxx> wrote:
> Just to confirm this commit fixes this bug, I built a Trusty test kernel, which can be downloaded from:
> http://kernel.ubuntu.com/~jsalisbury/lp1328295/
>
> Can you test this kernel to confirm it fixes this bug?

My target platform is arm64 - if you can provide arm64 binaries, or
the source, I could test it. Though, I have already tested a trusty
kernel with this cherry-pick on the target platform.

>  If it does, we
> can submit an SRU request to the kernel-team mailing list to have the
> commit included in Trusty.

This commit is already in the master-next branch for trusty:
http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-trusty.git;a=commit;h=3545bd96109d76abb535f2751cb7162bc519a11a

Based on this request:
https://lists.ubuntu.com/archives/kernel-team/2014-June/043580.html

Does that imply we're good?

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1328295

Title:
  [serial] use hw flow control if supported

Status in “linux” package in Ubuntu:
  Triaged
Status in “linux” source package in Trusty:
  In Progress

Bug description:
  HP Moonshot cartridges support hardware flow control, but right now
  only software assisted hw flow control is supported. This patch from
  upstream enables this functionality when exposed by firmware:

  commit 06aa82e498c144c7784a6f3d3b55458b272d6146
  Author: Murali Karicheri <m-karicheri2@xxxxxx>
  Date:   Thu May 1 15:04:53 2014 -0400

      serial: uart: add hw flow control support configuration
      
      8250 uart driver currently supports only software assisted hw flow
      control. The software assisted hw flow control maintains a hw_stopped
      flag in the tty structure to stop and start transmission and use modem
      status interrupt for the event to drive the handshake signals. This is
      not needed if hw has flow control capabilities. This patch adds a
      DT attribute for enabling hw flow control for a uart port. Also skip
      stop and start if this flag is present in flag field of the port
      structure.
      
      Signed-off-by: Murali Karicheri <m-karicheri2@xxxxxx>
      CC: Rob Herring <robh+dt@xxxxxxxxxx>
      CC: Pawel Moll <pawel.moll@xxxxxxx>
      CC: Mark Rutland <mark.rutland@xxxxxxx>
      CC: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx>
      CC: Kumar Gala <galak@xxxxxxxxxxxxxx>
      CC: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
      CC: Jiri Slaby <jslaby@xxxxxxx>
      CC: Santosh Shilimkar <santosh.shilimkar@xxxxxx>
      Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1328295/+subscriptions


References