kernel-packages team mailing list archive

[Brad Figg <brad.figg@xxxxxxxxxxxxx>]

This bug is missing log files that will aid in diagnosing the problem.
>From a terminal window please run:

apport-collect 1348277

and then change the status of the bug to 'Confirmed'.

If, due to the nature of the issue you have encountered, you are unable
to run this command, please add a comment stating that fact and change
the bug status to 'Confirmed'.

This change has been made by an automated script, maintained by the
Ubuntu Kernel Team.

** Changed in: linux (Ubuntu)
       Status: New => Incomplete

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1348277

Title:
  module compile error for aarch64

Status in “linux” package in Ubuntu:
  Incomplete

Bug description:
  When compiling an external module for aarch64 on Ubuntu 14.04, the
  compiler generates the following error:

  In file included from /home/ctuffli/dev/ubuntu-trusty/include/linux/netlink.h:6:0,
                   from /home/ctuffli/dev/ubuntu-trusty/include/uapi/scsi/scsi_netlink.h:25,
                   from /home/ctuffli/dev/ubuntu-trusty/include/scsi/scsi_transport_fc.h:32,
  <edited>
  /home/ctuffli/dev/ubuntu-trusty/include/linux/skbuff.h: In function ‘skb_can_coalesce’:
  /home/ctuffli/dev/ubuntu-trusty/include/linux/skbuff.h:2255:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
            off == frag->page_offset + skb_frag_size(frag);
                ^
  cc1: all warnings being treated as errors
  cc1: all warnings being treated as errors

  Although something like the below quiets the warning, it isn't clear
  to me this is the correct change

  diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
  index e9b1a3c..e3623cc 100644
  --- a/include/linux/skbuff.h
  +++ b/include/linux/skbuff.h
  @@ -2252,7 +2252,7 @@ static inline bool skb_can_coalesce(struct sk_buff *skb, int i,
   		const struct skb_frag_struct *frag = &skb_shinfo(skb)->frags[i - 1];
   
   		return page == skb_frag_page(frag) &&
  -		       off == frag->page_offset + skb_frag_size(frag);
  +		       off == (int)(frag->page_offset + skb_frag_size(frag));
   	}
   	return false;
   }

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1348277/+subscriptions