kernel-packages team mailing list archive

Thread
Date
[Bug 1348277] Re: module compile error for aarch64

To: kernel-packages@xxxxxxxxxxxxxxxxxxx
From: Ctuffli <ctuffli@xxxxxxxxx>
Date: Fri, 25 Jul 2014 01:06:02 -0000
Reply-to: Bug 1348277 <1348277@xxxxxxxxxxxxxxxxxx>
Sender: bounces@xxxxxxxxxxxxx
apport information

** Tags added: apport-collected trusty

** Description changed:

  When compiling an external module for aarch64 on Ubuntu 14.04, the
  compiler generates the following error:
  
  In file included from /home/ctuffli/dev/ubuntu-trusty/include/linux/netlink.h:6:0,
                   from /home/ctuffli/dev/ubuntu-trusty/include/uapi/scsi/scsi_netlink.h:25,
                   from /home/ctuffli/dev/ubuntu-trusty/include/scsi/scsi_transport_fc.h:32,
  <edited>
  /home/ctuffli/dev/ubuntu-trusty/include/linux/skbuff.h: In function ‘skb_can_coalesce’:
  /home/ctuffli/dev/ubuntu-trusty/include/linux/skbuff.h:2255:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
            off == frag->page_offset + skb_frag_size(frag);
                ^
  cc1: all warnings being treated as errors
  cc1: all warnings being treated as errors
  
  Although something like the below quiets the warning, it isn't clear to
  me this is the correct change
  
  diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
  index e9b1a3c..e3623cc 100644
  --- a/include/linux/skbuff.h
  +++ b/include/linux/skbuff.h
  @@ -2252,7 +2252,7 @@ static inline bool skb_can_coalesce(struct sk_buff *skb, int i,
   		const struct skb_frag_struct *frag = &skb_shinfo(skb)->frags[i - 1];
   
   		return page == skb_frag_page(frag) &&
  -		       off == frag->page_offset + skb_frag_size(frag);
  +		       off == (int)(frag->page_offset + skb_frag_size(frag));
   	}
   	return false;
   }
+ --- 
+ AlsaDevices: Error: command ['ls', '-l', '/dev/snd/'] failed with exit code 2: ls: cannot access /dev/snd/: No such file or directory
+ AplayDevices: Error: [Errno 2] No such file or directory
+ ApportVersion: 2.14.1-0ubuntu3.2
+ Architecture: arm64
+ ArecordDevices: Error: [Errno 2] No such file or directory
+ CRDA: Error: [Errno 2] No such file or directory
+ CurrentDmesg: [   17.335985] init: plymouth-upstart-bridge main process ended, respawning
+ DistroRelease: Ubuntu 14.04
+ HibernationDevice: RESUME=UUID=88388f89-d798-4675-9542-27cacae45a9d
+ IwConfig: Error: [Errno 2] No such file or directory
+ Lsusb: Error: command ['lsusb'] failed with exit code 1: unable to initialize libusb: -99
+ Package: linux (not installed)
+ PciMultimedia:
+  
+ ProcEnviron:
+  TERM=screen
+  PATH=(custom, no user)
+  XDG_RUNTIME_DIR=<set>
+  LANG=en_US.UTF-8
+  SHELL=/bin/bash
+ ProcFB:
+  
+ ProcKernelCmdLine: console=ttyS0,115200n8 ro
+ ProcVersionSignature: Ubuntu 3.13.0-32.57-generic 3.13.11.4
+ RelatedPackageVersions:
+  linux-restricted-modules-3.13.0-32-generic N/A
+  linux-backports-modules-3.13.0-32-generic  N/A
+  linux-firmware                             1.127.4
+ RfKill: Error: [Errno 2] No such file or directory
+ Tags:  trusty
+ Uname: Linux 3.13.0-32-generic aarch64
+ UpgradeStatus: No upgrade log present (probably fresh install)
+ UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
+ _MarkForUpload: True

** Attachment added: "AudioDevicesInUse.txt"
   https://bugs.launchpad.net/bugs/1348277/+attachment/4162394/+files/AudioDevicesInUse.txt

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1348277

Title:
  module compile error for aarch64

Status in “linux” package in Ubuntu:
  Confirmed

Bug description:
  When compiling an external module for aarch64 on Ubuntu 14.04, the
  compiler generates the following error:

  In file included from /home/ctuffli/dev/ubuntu-trusty/include/linux/netlink.h:6:0,
                   from /home/ctuffli/dev/ubuntu-trusty/include/uapi/scsi/scsi_netlink.h:25,
                   from /home/ctuffli/dev/ubuntu-trusty/include/scsi/scsi_transport_fc.h:32,
  <edited>
  /home/ctuffli/dev/ubuntu-trusty/include/linux/skbuff.h: In function ‘skb_can_coalesce’:
  /home/ctuffli/dev/ubuntu-trusty/include/linux/skbuff.h:2255:14: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
            off == frag->page_offset + skb_frag_size(frag);
                ^
  cc1: all warnings being treated as errors
  cc1: all warnings being treated as errors

  Although something like the below quiets the warning, it isn't clear
  to me this is the correct change

  diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
  index e9b1a3c..e3623cc 100644
  --- a/include/linux/skbuff.h
  +++ b/include/linux/skbuff.h
  @@ -2252,7 +2252,7 @@ static inline bool skb_can_coalesce(struct sk_buff *skb, int i,
   		const struct skb_frag_struct *frag = &skb_shinfo(skb)->frags[i - 1];
   
   		return page == skb_frag_page(frag) &&
  -		       off == frag->page_offset + skb_frag_size(frag);
  +		       off == (int)(frag->page_offset + skb_frag_size(frag));
   	}
   	return false;
   }
  --- 
  AlsaDevices: Error: command ['ls', '-l', '/dev/snd/'] failed with exit code 2: ls: cannot access /dev/snd/: No such file or directory
  AplayDevices: Error: [Errno 2] No such file or directory
  ApportVersion: 2.14.1-0ubuntu3.2
  Architecture: arm64
  ArecordDevices: Error: [Errno 2] No such file or directory
  CRDA: Error: [Errno 2] No such file or directory
  CurrentDmesg: [   17.335985] init: plymouth-upstart-bridge main process ended, respawning
  DistroRelease: Ubuntu 14.04
  HibernationDevice: RESUME=UUID=88388f89-d798-4675-9542-27cacae45a9d
  IwConfig: Error: [Errno 2] No such file or directory
  Lsusb: Error: command ['lsusb'] failed with exit code 1: unable to initialize libusb: -99
  Package: linux (not installed)
  PciMultimedia:
   
  ProcEnviron:
   TERM=screen
   PATH=(custom, no user)
   XDG_RUNTIME_DIR=<set>
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  ProcFB:
   
  ProcKernelCmdLine: console=ttyS0,115200n8 ro
  ProcVersionSignature: Ubuntu 3.13.0-32.57-generic 3.13.11.4
  RelatedPackageVersions:
   linux-restricted-modules-3.13.0-32-generic N/A
   linux-backports-modules-3.13.0-32-generic  N/A
   linux-firmware                             1.127.4
  RfKill: Error: [Errno 2] No such file or directory
  Tags:  trusty
  Uname: Linux 3.13.0-32-generic aarch64
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups: adm cdrom dip lpadmin plugdev sambashare sudo
  _MarkForUpload: True
  --- 
  AlsaDevices: Error: command ['ls', '-l', '/dev/snd/'] failed with exit code 2: ls: cannot access /dev/snd/: No such file or directory
  AplayDevices: Error: [Errno 2] No such file or directory
  ApportVersion: 2.14.1-0ubuntu3.2
  Architecture: arm64
  ArecordDevices: Error: [Errno 2] No such file or directory
  CRDA: Error: [Errno 2] No such file or directory
  CurrentDmesg: [   17.335985] init: plymouth-upstart-bridge main process ended, respawning
  DistroRelease: Ubuntu 14.04
  HibernationDevice: RESUME=UUID=88388f89-d798-4675-9542-27cacae45a9d
  IwConfig: Error: [Errno 2] No such file or directory
  Lsusb: Error: command ['lsusb'] failed with exit code 1: unable to initialize libusb: -99
  Package: linux (not installed)
  PciMultimedia:
   
  ProcEnviron:
   TERM=screen
   PATH=(custom, no user)
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  ProcFB:
   
  ProcKernelCmdLine: console=ttyS0,115200n8 ro
  ProcVersionSignature: Ubuntu 3.13.0-32.57-generic 3.13.11.4
  RelatedPackageVersions:
   linux-restricted-modules-3.13.0-32-generic N/A
   linux-backports-modules-3.13.0-32-generic  N/A
   linux-firmware                             1.127.4
  RfKill: Error: [Errno 2] No such file or directory
  Tags:  trusty
  Uname: Linux 3.13.0-32-generic aarch64
  UpgradeStatus: No upgrade log present (probably fresh install)
  UserGroups:
   
  _MarkForUpload: True

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1348277/+subscriptions
References

[Bug 1348277] [NEW] module compile error for aarch64
From: Ctuffli, 2014-07-24