← Back to team overview

kernel-packages team mailing list archive

[Bug 1358162] [NEW] skb_get_rxhash prematurely renamed to skb_get_hash

 

You have been subscribed to a public bug:

"3958afa1b272 net: Change skb_get_rxhash to skb_get_hash" is included in
the Trusty kernel like so:

commit df4530d690a14dd4b72e4eadc8fe845e3c5ba12c
Author: Tom Herbert <therbert@xxxxxxxxxx>
Date:   Sun Dec 15 22:12:06 2013 -0800

    net: Change skb_get_rxhash to skb_get_hash
    
    BugLink: http://bugs.launchpad.net/bugs/1328037
    
    Changing name of function as part of making the hash in skbuff to be
    generic property, not just for receive path.
    
    Signed-off-by: Tom Herbert <therbert@xxxxxxxxxx>
    Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
    (cherry picked from commit 3958afa1b272eb07109fd31549e69193b4d7c364)
    Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
    Acked-by: Brad Figg <brad.figg@xxxxxxxxxxxxx>


The referenced bug is about pulling in some up-to-date drivers.

Kernel module authors who need to work with many different kernel
versions deal with renames like this by using the KERNEL_VERSION macros
to determine which wrappers/stubs/whatever to include in a particular
build. However, because of this above change, which wasn't included in
upstream kernels until 3.14 (while Trusty is 3.13(+extra magic)) this
won't work.

I propose you add a compatibility macro. Luckily, it's a straight
rename, so this should be simple enough.

** Affects: linux (Ubuntu)
     Importance: Undecided
         Status: New

-- 
skb_get_rxhash prematurely renamed to skb_get_hash
https://bugs.launchpad.net/bugs/1358162
You received this bug notification because you are a member of Kernel Packages, which is subscribed to linux in Ubuntu.