kernel-packages team mailing list archive

[Tim Gardner <tim.gardner@xxxxxxxxxxxxx>]

** Also affects: linux (Ubuntu Utopic)
   Importance: Medium
       Status: Triaged

** Also affects: linux (Ubuntu Trusty)
   Importance: Undecided
       Status: New

** Changed in: linux (Ubuntu Utopic)
       Status: Triaged => Fix Released

** Changed in: linux (Ubuntu Trusty)
       Status: New => Fix Committed

** Changed in: linux (Ubuntu Trusty)
     Assignee: (unassigned) => Soren Hansen (soren)

** Patch added: "UBUNTU: SAUCE: Add compat macro for skb_get_hash"
   https://bugs.launchpad.net/ubuntu/trusty/+source/linux/+bug/1358162/+attachment/4181787/+files/0001-UBUNTU-SAUCE-Add-compat-macro-for-skb_get_hash.patch

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1358162

Title:
  skb_get_rxhash prematurely renamed to skb_get_hash

Status in “linux” package in Ubuntu:
  Fix Released
Status in “linux” source package in Trusty:
  Fix Committed
Status in “linux” source package in Utopic:
  Fix Released

Bug description:
  "3958afa1b272 net: Change skb_get_rxhash to skb_get_hash" is included
  in the Trusty kernel like so:

  commit df4530d690a14dd4b72e4eadc8fe845e3c5ba12c
  Author: Tom Herbert <therbert@xxxxxxxxxx>
  Date:   Sun Dec 15 22:12:06 2013 -0800

      net: Change skb_get_rxhash to skb_get_hash
      
      BugLink: http://bugs.launchpad.net/bugs/1328037
      
      Changing name of function as part of making the hash in skbuff to be
      generic property, not just for receive path.
      
      Signed-off-by: Tom Herbert <therbert@xxxxxxxxxx>
      Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
      (cherry picked from commit 3958afa1b272eb07109fd31549e69193b4d7c364)
      Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
      Acked-by: Brad Figg <brad.figg@xxxxxxxxxxxxx>

  
  The referenced bug is about pulling in some up-to-date drivers.

  Kernel module authors who need to work with many different kernel
  versions deal with renames like this by using the KERNEL_VERSION
  macros to determine which wrappers/stubs/whatever to include in a
  particular build. However, because of this above change, which wasn't
  included in upstream kernels until 3.14 (while Trusty is 3.13(+extra
  magic)) this won't work.

  I propose you add a compatibility macro. Luckily, it's a straight
  rename, so this should be simple enough.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1358162/+subscriptions