kernel-packages team mailing list archive

[Kylie Liang <kyliel@xxxxxxxxxxxxx>]

This is a note to let you know that I've just added the patch titled

    Tools: hv: vssdaemon: report freeze errors

to my char-misc git tree which can be found at
    git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git
in the char-misc-testing branch.

The patch will show up in the next release of the linux-next tree (usually
sometime within the next 24 hours during the week.)

The patch will be merged to the char-misc-next branch sometime soon, after it
pasts testing, and the merge window is open.

If you have any questions about this process, please let me know.


>From 7a401744d517864f8f2f2afba589e58a71d03aa6 Mon Sep 17 00:00:00 2001
From: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
Date: Mon, 10 Nov 2014 17:37:01 +0100
Subject: Tools: hv: vssdaemon: report freeze errors

When ioctl(fd, FIFREEZE, 0) results in an error we cannot report it to syslog
instantly since that can cause write to a frozen disk.
However, the name of the filesystem which caused the error and errno are
valuable and we would like to get a nice human-readable message in the log.
Save errno before calling vss_operate(VSS_OP_THAW) and report the error right
after.

Unfortunately, FITHAW errors cannot be reported the same way as we need to
finish thawing all filesystems before calling syslog().

We should also avoid calling endmntent() for the second time in case we
encountered an error during freezing of '/' as it usually results in SEGSEGV.

Signed-off-by: Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>
Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
Acked-by: Dexuan Cui <decui@xxxxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 tools/hv/hv_vss_daemon.c | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c index
b720d8f0f901..ee44f0d730ef 100644
--- a/tools/hv/hv_vss_daemon.c
+++ b/tools/hv/hv_vss_daemon.c
@@ -82,7 +82,7 @@ static int vss_operate(int operation)
     FILE *mounts;
     struct mntent *ent;
     unsigned int cmd;
-    int error = 0, root_seen = 0;
+    int error = 0, root_seen = 0, save_errno = 0;

     switch (operation) {
     case VSS_OP_FREEZE:
@@ -114,7 +114,6 @@ static int vss_operate(int operation)
         if (error && operation == VSS_OP_FREEZE)
             goto err;
     }
-    endmntent(mounts);

     if (root_seen) {
         error |= vss_do_freeze("/", cmd);
@@ -122,10 +121,19 @@ static int vss_operate(int operation)
             goto err;
     }

-    return error;
+    goto out;
 err:
-    endmntent(mounts);
+    save_errno = errno;
     vss_operate(VSS_OP_THAW);
+    /* Call syslog after we thaw all filesystems */
+    if (ent)
+        syslog(LOG_ERR, "FREEZE of %s failed; error:%d %s",
+               ent->mnt_dir, save_errno, strerror(save_errno));
+    else
+        syslog(LOG_ERR, "FREEZE of / failed; error:%d %s", save_errno,
+               strerror(save_errno));
+out:
+    endmntent(mounts);
     return error;
 }

--
2.1.3

-- 
You received this bug notification because you are a member of Kernel
Packages, which is subscribed to linux in Ubuntu.
https://bugs.launchpad.net/bugs/1400628

Title:
  Failed online backup(hypervvssd) when the guest mount udf/squashfs
  type

Status in linux package in Ubuntu:
  Incomplete

Bug description:
  RHEL7.0 reports below issue and this should be a common issue. 
  https://bugzilla.redhat.com/show_bug.cgi?id=1160584 

  And 2 patches are accepted by community. Could you please include those patches in
  OL7? Thank you.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1400628/+subscriptions