kicad-developers team mailing list archive

[core@...]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Bryan,

On Wed, Dec 07, 2005 at 11:46:18PM -0700, Bryan Stillwell wrote:
> I've been getting a bit more familiar with wxWidgets and decided to
> clean up the kicad launcher interface ever so slightly. Please take a
> look at the following comparison:
> 
> http://kicad.bokeoa.com/bryan/kicad-cosmetic1.png

Very subtle but nice. At first I couldn't notice any
differences. :) I'm still digging through the differences
between my unicode hack and jean's release candidate. Only 3k
differences or so! ;) Wish me luck... i suppose I will at least
highlight a very small few which I'd like to have included that
are not yet in the release candidate.

1. GetEditorName: in my patch I've added a file mask in the case
that __WINDOWS__ is undefined. This allows *nix machines to
choose an editor.

2. ProcessFct: in the ID_BROWSE_AN_SELECT_FILE case same idea as
above. On some systems the .* and *.* mask aren't enough. Oh
and also in ID_SELECT_PREFERED_EDITOR

3. All of the DisplayError strings should be wrapped in _() not
wxT() in my opinion. *shrug* :) Translations would be nice..

4. I think the use of native wxString functions can greatly
reduce WildCompareString (and others) like this:

if (case_sensitive) return string_to_tst.Matches(pattern);
else return string_to_tst.Lower().Matches(pattern.Lower());

Other than this... at this hour of the night I would say
everything looks quite good! Nice work Jean. Let me know if I
should try to merge our diffs. I have just found a nice tool to
go through and do the work:

http://bokeoa.com/~core/images/kdiff3.png

Jean, please consider some of the above listed changes. I can
send a smaller diff against your release candidate if you
prefer.

peace,
Charlie

- --

There is no Death. /\___/\ Charles Stevenson
Only a change of / /\ /\ \ Psychonautified
worlds. | ³ù ù³ | hacker. 
\ _ /
Seattle [Sealth] ( ) One truth, love!

A4C6 C505 6949 B942 9C36 CEF4 180B 8BAF 13B2 7893

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)

iD8DBQFDl+CFGAuLrxOyeJMRApdlAJ9fU/XA1iq0pNsbEgI6PhuVCqbtfgCfYlzC
tiA1B8xYo9Uwq/OElHTRFZ8=
=cgjZ
-----END PGP SIGNATURE-----