← Back to team overview

kicad-developers team mailing list archive

Re: [pcbnew] ZONE_CONTAINER does not save or use PadInZone

 

Here is the patch

I have added an option to the ZAux line in .brd file

Tested with my board.

Cheers,Rok

Kanardia d.o.o.
ul. heroja Rojška 70
3000 Celje
Tel: +386 3 424 42 42
Fax: +386 3 424 41 95


Rok Markovic pravi:
> 
> 
> Hi
> 
> I would think this as of a bug, but as i looked through code, there
> is no obvios reason why nobody implemented saving that flag.
> Each of the ZONE_CONTAINERS have variable m_PadOption, but zone_by_polygon
> sets static variable for each instance of the class.
> 
> Problematic is line 794 in zones_by_polygon.cpp. If this line is
> commented out zones are working as expected, but option is not saved.
> 
> I can send a patch to do this too.
> 
> I really need this feature.
> 
> How can I add a option in file format, not breaking anything.
> 
> Cheer,
> Rok
> 
> -- 
> Kanardia d.o.o.
> ul. heroja Rojška 70
> 3000 Celje
> Tel: +386 3 424 42 42
> Fax: +386 3 424 41 95
> 
> 
 --------------010508050009080208010806 Content-Type: text/plain;
name="Save_and_use_pad_option.dif"
Content-Transfer-Encoding: base64
Content-Disposition: inline;
filename="Save_and_use_pad_option.dif"

SW5kZXg6IHBjYm5ldy96b25lc19ieV9wb2x5Z29uLmNwcAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBw
Y2JuZXcvem9uZXNfYnlfcG9seWdvbi5jcHAJKHJldmlzaW9uIDk2MykKKysrIHBjYm5ldy96
b25lc19ieV9wb2x5Z29uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtODUwLDcgKzg1MCw3IEBA
CiAKICAgICBBZmZpY2hlXzFfUGFyYW1ldHJlKCB0aGlzLCAyMiwgXyggIk5ldE5hbWUiICks
IG1zZywgUkVEICk7CiAgICAgd3hCdXN5Q3Vyc29yIGR1bW15OyAgICAgLy8gU2hvd3MgYW4g
aG91cmdsYXNzIGN1cnNvciAocmVtb3ZlZCBieSBpdHMgZGVzdHJ1Y3RvcikKLSAgICB6b25l
X2NvbnRhaW5lci0+bV9QYWRPcHRpb24gICAgID0gc19ab25lX1BhZF9PcHRpb25zOworLy8g
ICAgIHpvbmVfY29udGFpbmVyLT5tX1BhZE9wdGlvbiAgICAgPSBzX1pvbmVfUGFkX09wdGlv
bnM7CiAgICAgem9uZV9jb250YWluZXItPm1fWm9uZUNsZWFyYW5jZSA9IGdfRGVzaWduU2V0
dGluZ3MubV9ab25lQ2xlYXJlbmNlOwogICAgIHpvbmVfY29udGFpbmVyLT5tX0dyaWRGaWxs
VmFsdWUgPSBnX0dyaWRSb3V0aW5nU2l6ZTsKICAgICBpbnQgZXJyb3JfbGV2ZWwgPSB6b25l
X2NvbnRhaW5lci0+RmlsbF9ab25lKCB0aGlzLCBEQywgdmVyYm9zZSApOwpJbmRleDogcGNi
bmV3L2NsYXNzX3pvbmUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHBjYm5ldy9jbGFzc196b25l
LmNwcAkocmV2aXNpb24gOTYzKQorKysgcGNibmV3L2NsYXNzX3pvbmUuY3BwCSh3b3JraW5n
IGNvcHkpCkBAIC0xMTAsNyArMTEwLDcgQEAKICAgICAgICAgYnJlYWs7CiAgICAgfQogCi0g
ICAgcmV0ID0gZnByaW50ZiggYUZpbGUsICJaQXV4ICVkICVjXG4iLCBjb3JuZXJzX2NvdW50
LCBvdXRsaW5lX2hhdGNoICk7CisgICAgcmV0ID0gZnByaW50ZiggYUZpbGUsICJaQXV4ICVk
ICVjICVkXG4iLCBjb3JuZXJzX2NvdW50LCBvdXRsaW5lX2hhdGNoLCBtX1BhZE9wdGlvbiAp
OwogICAgIGlmKCByZXQgPCAyICkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCkBAIC0xOTgs
NyArMTk4LDcgQEAKICAgICAgICAgICAgIGludCAgeCA9IDA7CiAgICAgICAgICAgICBjaGFy
IGhvcHRbMTBdOwogICAgICAgICAgICAgdGV4dCA9IExpbmUgKyA0OwotICAgICAgICAgICAg
cmV0ICA9IHNzY2FuZiggdGV4dCwgIiVkICVjIiwgJngsIGhvcHQgKTsKKyAgICAgICAgICAg
IHJldCAgPSBzc2NhbmYoIHRleHQsICIlZCAlYyAlZCIsICZ4LCBob3B0LCAmbV9QYWRPcHRp
b24gKTsKICAgICAgICAgICAgIGlmKCByZXQgPCAyICkKICAgICAgICAgICAgICAgICBlcnJv
ciA9IHRydWU7CiAgICAgICAgICAgICBlbHNlCkBAIC01NDAsNyArNTQwLDcgQEAKICAgICAg
ICAgZWxzZQogICAgICAgICAgICAgbXNnID0gd3hUKCAiPG5vbmFtZT4iICk7CiAgICAgfQot
ICAgIGVsc2UgICAgLy8gYSBuZXRjb2RlIDzgIGlzIGFuIGVycm9yCisgICAgZWxzZSAgICAv
LyBhIG5ldGNvZGUgPCAwIGlzIGFuIGVycm9yCiAgICAgewogICAgICAgICBtc2cgPSB3eFQo
ICIgWyIgKTsKICAgICAgICAgbXNnIDw8IG1fTmV0bmFtZSArIHd4VCggIl0iICk7Cg==
 --------------010508050009080208010806-- 




Follow ups

References