kicad-developers team mailing list archive

[Moses O McKnight <moses@...>]

On Sun, 2008-07-20 at 12:03 +0200, jean-pierre charras wrote: 
> Moses O McKnight a écrit :
> >
> > Hi,
> >
> > Here's a patch for files.cpp in pcbnew.
> >
> > This fixes the problem with "append board" changing the name of the
> > board current board to "noname.brd"
> >
> > Let me know if something doesn't work or if there is a reason this
> > should not be done.
> >
> A reason is the append function is a rather dangerous function.
> One can easily break a board.
> And in all cases the result does not match with a schematic.
> (For instance DRC cannot be used)
> 
> So changing the name of the new bord is a reasonnable prudence.

That makes sense, but the current implementation is somewhat awkward
IMO. I needed to append 3 boards into one and it changed the name every
time, even though I started with a new board so I wouldn't break one of
my good boards. Not only that but if you save the file without noticing
the name changed there is no indication of the name change. Then if you
leave the name as "noname.brd" it does not change the name again!

Maybe a better way would be to have a flag in the brd file with would
indicate that boards were appended. If the flag is not set (no board
has been appended to the file) then after appending a board it would
prompt the user to rename the board when he went to save it, and it
would set the flag in the file. After the flag is set in the file then
any further append operations would not prompt to rename the file.

Does that sound any good?

Moses