kicad-developers team mailing list archive

["tomas.modeer" <tomas.modeer@...>]

Seems the thickness and fill arguments of PlotCirclePS got mixed up.
Why is the fill argument not a boolean? 
I put a patch in the file area, plot_rtn.patch, but repeat it here as 
well:

Index: pcbnew/plot_rtn.cpp
===================================================================
--- pcbnew/plot_rtn.cpp	(revision 1178)
+++ pcbnew/plot_rtn.cpp	(working copy)
@@ -791,7 +791,7 @@
break;
 
case PLOT_FORMAT_POST:
- PlotCirclePS( centre, radius * 2, thickness, 0);
+ PlotCirclePS( centre, radius * 2, 0, thickness);
break;
}
}

/tomas

--- In kicad-devel@xxxxxxxxxxxxxxx, Dick Hollenbeck <dick@...> wrote:
>
> 
> Thanks Lorenzo.
> 
> Since the patch looks plausible, I will be applying it in a few 
minutes.
> 
> I will not have time to test it. It there is a world wide epidemic 
of 
> exploding laser jet printers, then that is not on me.
> 
> 
> Dick
> 
> 
> > --- In kicad-devel@xxxxxxxxxxxxxxx, "Lorenzo" <lomarcan@> wrote:
> >
> > OK, done that. The BgFill is treated as a normal Fill, for now, 
but
> > it's all in the postscript prefix, so it can be changed easily. 
HPGL
> > plotting is NOT changed, by design, since a lot of the importers 
don't
> > recognize the fill commands. Said that it could be implemented 
using
> > the WG, RA, and the (HPGL/2 IIRC) PM/FP filled polygon commands.
> >
> > The real question is, really, today WHO wants an hpgl export? :D
> >
> > I put the patch in the files zone.
> >
> > Awaiting for comments or issues :P
> >
> >
>