← Back to team overview

kicad-developers team mailing list archive

Re: Command ID refactoring.


Wayne Stambaugh wrote:
I just want to make everyone aware of the command ID refactoring commit
I just made. I separated the application specific command IDs in
"include/id.h" to separate files in each application (kicad, cvpcb,
gerbview, etc.). The only IDs remaining in "id.h" are common to
multiple applications. This prevents the entire project from being
rebuilt when adding a new command ID to any single application.

Did you actually test this "compile avoidance assumption" ? Because sometimes just header file nesting can break this independence.
(IMO, unless the goal is actually achieved, I would not prefer the split.)


future reference, please put application specific IDs in the appropriate
header file ( "pcbnew_id.h" for PCBNew command IDs ). Only command IDs
shared across more than on application should be put in "include/id.h".



Yahoo! Groups Links

Follow ups