kicad-developers team mailing list archive
Mailing list archive
Layers and elements visibility (internals)
Greetings to All,
I changed the way how visibility is treated internaly.
Changed 26 files:
Almost done, only dialog "Layer color and visibility" half broken yet.
When I arrive home I will finish it. I will just make the colors dialog work again, enhancements I will leave for later.
Found some interesting things:
1) gerbview/gerbview_config.h was using variable "g_DesignSettings.m_PcbGridColor", but the color Gerbview uses come from "g_GridColor". I suppose this made Gerbvied changes to grid color not being preserved betweens sessions.
EDA_BoardDesignSettings members not used: m_PcbGridColor, m_ModuleTextCMPColor, m_ModuleTextCUColor, m_ModuleTextNOVColor, m_AnchorColor, m_PadCUColor, m_PadCMPColor.
Following global variables used instead:
pcbcommon.cpp: g_AnchorColor, g_ModuleTextCMPColor, g_ModuleTextCUColor, g_ModuleTextNOVColor, g_PadCUColor, g_PadCMPColor.
I understand this separation may have been due to to the fact that some variables are used only by Pcbnew and others by other targets also (even by Eeschema: grid color), but could we arrange things a little better?