← Back to team overview

kicad-developers team mailing list archive

Thread
Date

Is this condition in pcbnew correct?

To: kicad-devel@xxxxxxxxxxxxxxx
From: "Sergey A. Borshch" <sb-sf@...>
Date: Sat, 05 Dec 2009 22:13:16 +0200
User-agent: Thunderbird 2.0.0.23 (Windows/20090812)

Hello everybody.

I'm learning KiCAD sources in order to add some hotkeys. And I found one condition which seems tome to be not correct:

pcbnew/hotkeys.cpp, line 730 (svn rev 2135):

DrawStruct = PcbGeneralLocateAndDisplay();
if( DrawStruct && DrawStruct->Type() != TYPE_TRACK )
return FALSE;
Delete_Track( DC, (TRACK*) DrawStruct );

Shoudn't this condition be written as
if( !DrawStruct || DrawStruct->Type() != TYPE_TRACK )
return FALSE;

?

--
Regards,
Sergey A. Borshch mailto: sb-sf@...