← Back to team overview

kicad-developers team mailing list archive

OSX Patch review request

 

This fixes a couple of problems:
The first was the possibility to the window taskbar to go under the fixed menubar making impossible manage the window.
The second was to avoid to use MenuID 0 as asserts wxwindows (on Mac is impossible to use MenuID = 0)

--
Marco

Index: common/basicframe.cpp
===================================================================
--- common/basicframe.cpp	(revision 2209)
+++ common/basicframe.cpp	(working copy)
@@ -19,7 +19,6 @@
#include "wxstruct.h"
#include "macros.h"
 
-
/*
* Class constructor for WinEDA_BasicFrame general options
*/
@@ -112,7 +111,7 @@
// for macOSX, the window must be below system (macOSX) toolbar
Ypos_min = GetMBarHeight();
#else
- Ypos_min = 0;
+ Ypos_min = 20;
#endif
if( m_FramePos.y < Ypos_min )
m_FramePos.y = Ypos_min;
Index: gerbview/wxGerberFrame.h
===================================================================
--- gerbview/wxGerberFrame.h	(revision 2209)
+++ gerbview/wxGerberFrame.h	(working copy)
@@ -18,6 +18,7 @@
*/
enum id_gerbview_frm
{
+ ID_LOOSE, // A MenuItem ID of Zero does not work under Mac
ID_GERBVIEW_SHOW_LIST_DCODES,
ID_GERBVIEW_LOAD_DRILL_FILE,
ID_GERBVIEW_LOAD_DCODE_FILE,







Follow ups