kicad-developers team mailing list archive

[Lorenzo Marcantonio <l.marcantonio@xxxxxxxxxxxx>]

On Fri, 9 Jul 2010, Dick Hollenbeck wrote:

> 1) If moving away from int for aUnits, must we go to bool?  Can we at
> least go to a new enum rather than a bool?  Why burn the bridge to being
> able to support other units in the future?  (There is no cost to
> preserving the bridge.)

Agreed, the right type should be an enum (someone could argue for class
singletons, but I am personally *against* OO). I used a bool since *some*
function used an int and *some* only the bool. In fact the CENTIMETRE
unit (used once, and only for the plot pen speed which isn't either used
in kicad's unit) was treated more or less inconsistently.

> parameter.   I prefer aUnits.

What does the 'a' stand for, BTW? and why units since it singular (THE
unit, not some of these...)

> 3) Your single line C comments should really be C++ comments and have
> blank lines above them.

I'm more a C/Lisp programmer than a C++ one :P

> 4) Your bracket placement is not compatible with established style.
>
> 5) There should be no spaces after while, for, or if.
>
> 6) There should be a space after most any (.

Uhmm the uncrustify config is still valid? (as a personal note
I have /never/ seen an indentation convention like that you use...
expecially for the parenthesis).

Working on the issues.

--
Lorenzo Marcantonio
Logos Srl