← Back to team overview

kicad-developers team mailing list archive

Re: Revision 2604 has broken cvpcb and some random warnings

 

The warnings from block.cpp are my bad. That should teach me to do a
debug build. The attached patch adds a default handler (that does
nothing) and gets rid of the warnings.

marco

On Fri, Nov 12, 2010 at 1:06 PM, Fabio Varesano
<fabio.varesano@xxxxxxxxx> wrote:
> Here compiling didn't hang but I'm also getting a lot of warnings.
> wxgtk 2.8.11. gcc 4.5.1
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/class_pad_draw_functions.cpp:
> In member function ‘void D_PAD::DrawShape(EDA_Rect*, wxDC*,
> PAD_DRAWINFO&)’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/class_pad_draw_functions.cpp:593:36:
> warning: converting ‘false’ to pointer type for argument 13 of ‘void
> DrawGraphicText(WinEDA_DrawPanel*, wxDC*, const wxPoint&, EDA_Colors,
> const wxString&, int, const wxSize&, GRTextHorizJustifyType,
> GRTextVertJustifyType, int, bool, bool, void (*)(int, int, int, int),
> PLOTTER*)’
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/class_libentry.cpp:
> In member function ‘void LIB_COMPONENT::Draw(WinEDA_DrawPanel*, wxDC*,
> const wxPoint&, int, int, int, int, const TRANSFORM&, bool, bool, bool)’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/class_libentry.cpp:325:87:
> warning: converting ‘false’ to pointer type for argument 6 of ‘virtual
> void LIB_DRAW_ITEM::Draw(WinEDA_DrawPanel*, wxDC*, const wxPoint&,
> int, int, void*, const TRANSFORM&)’
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/class_libentry.h:
> In member function ‘virtual void
> SCH_COMPONENT::GetConnectionPoints(std::vector<wxPoint>&) const’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/class_libentry.h:374:92:
> warning: ‘pin’ may be used uninitialized in this function
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/sch_component.cpp:1660:14:
> note: ‘pin’ was declared here
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/sch_field.cpp:
> In member function ‘virtual void SCH_FIELD::Draw(WinEDA_DrawPanel*,
> wxDC*, const wxPoint&, int, int)’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/sch_field.cpp:154:40:
> warning: converting ‘false’ to pointer type for argument 13 of ‘void
> DrawGraphicText(WinEDA_DrawPanel*, wxDC*, const wxPoint&, EDA_Colors,
> const wxString&, int, const wxSize&, GRTextHorizJustifyType,
> GRTextVertJustifyType, int, bool, bool, void (*)(int, int, int, int),
> PLOTTER*)’
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/sch_sheet.cpp:
> In member function ‘virtual void SCH_SHEET::Draw(WinEDA_DrawPanel*,
> wxDC*, const wxPoint&, int, int)’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/sch_sheet.cpp:582:42:
> warning: converting ‘false’ to pointer type for argument 13 of ‘void
> DrawGraphicText(WinEDA_DrawPanel*, wxDC*, const wxPoint&, EDA_Colors,
> const wxString&, int, const wxSize&, GRTextHorizJustifyType,
> GRTextVertJustifyType, int, bool, bool, void (*)(int, int, int, int),
> PLOTTER*)’
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/eeschema/sch_sheet.cpp:594:42:
> warning: converting ‘false’ to pointer type for argument 13 of ‘void
> DrawGraphicText(WinEDA_DrawPanel*, wxDC*, const wxPoint&, EDA_Colors,
> const wxString&, int, const wxSize&, GRTextHorizJustifyType,
> GRTextVertJustifyType, int, bool, bool, void (*)(int, int, int, int),
> PLOTTER*)’
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/gerbview/draw_gerber_screen.cpp:
> In function ‘void Show_Items_DCode_Value(WinEDA_DrawPanel*, wxDC*,
> BOARD*, int)’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/gerbview/draw_gerber_screen.cpp:207:49:
> warning: converting ‘false’ to pointer type for argument 13 of ‘void
> DrawGraphicText(WinEDA_DrawPanel*, wxDC*, const wxPoint&, EDA_Colors,
> const wxString&, int, const wxSize&, GRTextHorizJustifyType,
> GRTextVertJustifyType, int, bool, bool, void (*)(int, int, int, int),
> PLOTTER*)’
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:
> In function ‘void drawPickedItems(WinEDA_DrawPanel*, wxDC*, wxPoint)’:
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘NOT_USED’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘EOT’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_NOT_INIT’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_PCB’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCREEN’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_PAD’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_TEXTE_MODULE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_EDGE_MODULE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_ZONE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_ZONE_EDGE_CORNER’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_BOARD_ITEM_LIST’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_POLYLINE_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_JUNCTION_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCH_TEXT’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCH_LABEL’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCH_GLOBALLABEL’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCH_HIERLABEL’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCH_COMPONENT’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_SEGMENT_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_BUSENTRY_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_SHEET_STRUCT_TYPE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_HIERARCHICAL_PIN_SHEET_STRUCT_TYPE’
> not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_SCH_MARKER’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_NOCONNECT_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘DRAW_PART_TEXT_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘SCREEN_STRUCT_TYPE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘BLOCK_LOCATE_STRUCT_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘LIB_COMPONENT_T’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘LIB_ALIAS_T’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_ARC_DRAW_TYPE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_CIRCLE_DRAW_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_GRAPHIC_TEXT_DRAW_TYPE’ not
> handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_RECT_DRAW_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_POLYLINE_DRAW_TYPE’ not handled
> in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_LINE_DRAW_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_BEZIER_DRAW_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_PIN_DRAW_TYPE’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘COMPONENT_FIELD_DRAW_TYPE’ not handled in
> switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘TYPE_GERBER_DRAW_ITEM’ not handled in switch
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/block.cpp:653:15:
> warning: enumeration value ‘MAX_STRUCT_TYPE_ID’ not handled in switch
>
>
> /home/fabio/Programs/kicad-arch/kicad-bzr/src/kicad/pcbnew/export_vrml.cpp:760:13:
> warning: ‘void export_vrml_zones(BOARD*)’ defined but not used
>
>
>
> On 11/12/2010 11:02 AM, Jerry Jacobs wrote:
>> [ 70%] Building CXX object cvpcb/CMakeFiles/cvpcb.dir/cvpcb.cpp.o
>> /Users/jerry/Projects/kicad/testing/cvpcb/cvpcb.cpp: In member
>> function ‘virtual bool WinEDA_App::OnInit()’:
>> /Users/jerry/Projects/kicad/testing/cvpcb/cvpcb.cpp:87: error:
>> ‘ID_KICAD_ABOUT’ was not declared in this scope
>> /Users/jerry/Projects/kicad/testing/cvpcb/cvpcb.cpp:88: error:
>> ‘ID_OPTIONS_SETUP’ was not declared in this scope
>> make[2]: *** [cvpcb/CMakeFiles/cvpcb.dir/cvpcb.cpp.o] Error 1
>> make[1]: *** [cvpcb/CMakeFiles/cvpcb.dir/all] Error 2
>>
>> Including id.h seems to fix this.
>>
>> Also some not nice warning include:
>>
>> [ 87%] Building CXX object pcbnew/CMakeFiles/pcbnew.dir/block.cpp.o
>> /Users/jerry/Projects/kicad/testing/pcbnew/block.cpp: In function
>> ‘void drawPickedItems(WinEDA_DrawPanel*, wxDC*, wxPoint)’:
>> /Users/jerry/Projects/kicad/testing/pcbnew/block.cpp:653: warning:
>> enumeration value ‘NOT_USED’ not handled in switch
>> /Users/jerry/Projects/kicad/testing/pcbnew/block.cpp:653: warning:
>> enumeration value ‘EOT’ not handled in switch
>> /Users/jerry/Projects/kicad/testing/pcbnew/block.cpp:653: warning:
>> enumeration value ‘TYPE_NOT_INIT’ not handled in switch
>> /Users/jerry/Projects/kicad/testing/pcbnew/block.cpp:653: warning:
>> enumeration value ‘TYPE_PCB’ not handled in switch
>> /Users/jerry/Projects/kicad/testing/pcbnew/block.cpp:653: warning:
>> enumeration value ‘TYPE_SCREEN’ not handled in switch
>>
>> And this:
>>
>> /Users/jerry/Projects/kicad/testing/pcbnew/export_vrml.cpp:760:
>> warning: ‘void export_vrml_zones(BOARD*)’ defined but not used
>>
>> And this:
>>
>> In file included from /Users/jerry/Projects/kicad/testing/common/xnode.cpp:26:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h: In member
>> function ‘wxString XNODE::GetAttribute(const wxString&, const
>> wxString&) const’:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h:76: warning:
>> ‘GetPropVal’ is deprecated (declared at
>> /opt/wxwidgets/65968/include/wx-2.9/wx/xml/xml.h:229)
>> /Users/jerry/Projects/kicad/testing/include/xnode.h: In member
>> function ‘bool XNODE::GetAttribute(const wxString&, wxString*) const’:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h:80: warning:
>> ‘GetPropVal’ is deprecated (declared at
>> /opt/wxwidgets/65968/include/wx-2.9/wx/xml/xml.h:226)
>> /Users/jerry/Projects/kicad/testing/include/xnode.h: In member
>> function ‘wxXmlAttribute* XNODE::GetAttributes() const’:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h:88: warning:
>> ‘GetProperties’ is deprecated (declared at
>> /opt/wxwidgets/65968/include/wx-2.9/wx/xml/xml.h:223)
>>
>> And last:
>>
>> In file included from
>> /Users/jerry/Projects/kicad/testing/eeschema/netform.cpp:53:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h: In member
>> function ‘wxString XNODE::GetAttribute(const wxString&, const
>> wxString&) const’:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h:76: warning:
>> ‘GetPropVal’ is deprecated (declared at
>> /opt/wxwidgets/65968/include/wx-2.9/wx/xml/xml.h:229)
>> /Users/jerry/Projects/kicad/testing/include/xnode.h: In member
>> function ‘bool XNODE::GetAttribute(const wxString&, wxString*) const’:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h:80: warning:
>> ‘GetPropVal’ is deprecated (declared at
>> /opt/wxwidgets/65968/include/wx-2.9/wx/xml/xml.h:226)
>> /Users/jerry/Projects/kicad/testing/include/xnode.h: In member
>> function ‘wxXmlAttribute* XNODE::GetAttributes() const’:
>> /Users/jerry/Projects/kicad/testing/include/xnode.h:88: warning:
>> ‘GetProperties’ is deprecated (declared at
>> /opt/wxwidgets/65968/include/wx-2.9/wx/xml/xml.h:223)
>>
>> I compile on OS X with wxWidgets 2.9.2 (svn revision 65968)
>>
>> Kind Regards,
>> Jerry Jacobs
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>
=== modified file 'pcbnew/block.cpp'
--- pcbnew/block.cpp	2010-11-11 21:46:55 +0000
+++ pcbnew/block.cpp	2010-11-12 11:32:49 +0000
@@ -704,6 +704,8 @@
             pcbMarker->Draw( aPanel, aDC, GR_XOR, aOffset );
             break;
         }
+        default:
+            break;
         }
     }
     g_Offset_Module = wxPoint( 0, 0 );


Follow ups

References