← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Saving plot dialog settings


On 01/28/2011 11:18 AM, Marco Mattila wrote:
> On Fri, Jan 28, 2011 at 12:21 AM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>> Any "complex" string that is capable of having either whitespace or quotes
>> in it should be wrapped using
>> aFormatter->Quoted( CONV_TO_UTF8(blah) ).c_str(),
> I'm working on this now. Should there be something like
> if( strchr( quote_char, *wrapee ) )
>       return quote_char;
> in the for loop of OUTPUTFORMATTER::GetQuotedChar? Otherwise it seems
> that a string with internal quotes is not wrapped in quotes.

Here are two things, either of which would define a problem:

1) Is it incompatible with the what freerouter expects or can tolerate?

2) Is it incompatible with what the DSNLEXER expects or can tolerate?

I don't know that the condition you state meets either of these criteria,
but I will investigate and get back to you.  The Quoted() function was
written to make DSNLEXER happy and however unusual things look there, as
long as those two code bodies agree, then it may not be an issue.  What does
it mean to "agree"?  This is the round-tripping of 8 bit text to and from
the quoted form, those two strings need to agree.  This may not look like
what you expect or want on disk.

Having said that, then are you saying a string like this:


On the way out, *before* quoting will be a problem?  Will not come back in
via DSNLEXER?  Have you verified this problem string with actual testing?



Follow ups