← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Saving plot dialog settings


On 2/8/2011 4:36 PM, Marco Mattila wrote:
> On Tue, Feb 1, 2011 at 9:46 PM, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> wrote:
>> 6) Bonus points for using a wxCheckListBox for selecting the layers.  This way
>> when PCBNew supports unlimited layers, the dialog box will not need to be
>> updated again.
> I've been testing this (see attachment). I think that it might be ok
> to put copper and technical layers on the same list. If needed for
> clarity, something like "(copper)" could be appended to the names of
> copper layers. However, all this would be mainly for looks right now,
> since the layer selection is currently saved in a long bit field which
> doesn't work very well for an unlimited number of layers. Any
> comments?


It looks good.  It certainly is a huge improvement over the old dialog.  Aside
from some minor alignment issues the only comment I have is what does the
"Apply Settings" button do?  If it just copies the dialog settings to
application variables, why not do this on close if there are any changes?  If
it does more than that, then a more descriptive button name may be useful.

Thank you for your time and effort.


> marco
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Follow ups