← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Moveable toolbars


On 8/29/2011 6:45 PM, hauptmech wrote:
> Here's the diff I promised.
> The main thing I'm wondering is does the idiom (inheriting the
> wxPaneInfo class) suit you guys?

My only suggestion is that you keep the function naming in line with the base
wxAuiPaneInfo class.  Instead of init_vertical_toolbar(), use
VerticalToolbarPane().  This has a similar look and feel to the wxAuiPaneInfo
ToolbarPane() function and it follows the public function naming requirements
documented in the Kicad coding style policy.


> The purpose of this patch (when finished) would be to fix erroneous
> usage of the toolbar api and centralize the common portion.
> If it looks like it's in the right direction I'll add comments,
> propagate it to the other apps and change the defaults from moveable
> toolbars to ones that match the present behavior.
> I'll wait to work on the moveable aspect until later as the discussion
> matures a bit.
> -hauptmech
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp