← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Centralized paneinfo


On 9/1/2011 6:06 AM, hauptmech wrote:
> Attached is a patch proposal for centralizing the configuration of Aui
> panes in prep for a user configurable interface.
> The outward GUI remains unchanged. When we are ready to allow moveable
> toolbars, a quick change to the EDA_PANEINFO class, already prepped,
> will do this.
> * Added EDA_PANEINFO class to centralize AuiPanel configuration
> * Changed the frame initialization of each app to use EDA_PANEINFO
> * Fixed erroneous use of Aui layout api in some cases.
> ...I'm off on holiday for a week. I'll answer any issues after that.
> Regards,
> Hauptmech

I found an issue with this patch.  Take a look at last horizontal tool bar
button in the attached image.  This problem also exists in the EESchema,
library editor, cvpcb, cvpcb footprint viewer, pcbnew, and module editor main
windows.  It appears to effect both horizontal and vertical tool bars and it is
always the last tool bar button.  I get the same behavior on Debian testing
(wxWidgets 2.8.10) and Windows (wxWidgets 2.9.2).  I messed around a bit with
the wxAuiInfoPane settings but I could not resolve the issue.  Your patch also
had trailing white space.


> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: kicad_toolbar_issue.PNG
Description: PNG image

Follow ups