← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] new hotkeys window + some menu entry mistakes corrected + CONTRIBUTE file added


I kind of get point. My consideration was more about a good looking
menu then 10% coherence. See in attachment how the great TextMate
does. I just think that the <> is redundant because when for instance
"B" appears next to Bus in the Place menu, that means that the "B" is
the shortcut key for the command "place bus", it is not necessary to
indicate <B>. I also think that it is important to justify all keys
right. Notice that (in my opinion) the same thing should be done in
the ohtkeys list window.

Now if commands change (or become inactive) because the mouse is
somewhere outside the sheet or whatever and the key does not work (as
I think is the case to mention), well no worries, I guess it is just
the way it is. Regardless, from an aesthetic point of view, I think we
should follow the TextMate way (which is also your way for CTRL-F for

I do not think that people will ever understand the difference between
your CTRL-F and your <B>.

This is just my opinion of course. I hope this will help.

On Sat, Sep 3, 2011 at 3:53 PM, jean-pierre charras
<jp.charras@xxxxxxxxxx> wrote:
> Le 03/09/2011 15:29, fabrizio a écrit :
>> Dear All,
>> this is my first patch, I hope it will be all right. This is what I have
>> done.
> ....
>> 2) hotkeys in the "Place" top menu are now properly displayed. They
>> are right justified and appear without the unnecessary "<>".
> This is not possible:
> As clearly written in comments in many places,
> when a key appear inside "<>" this is a comment, not a hotkey equivalent to
> the menu.
> This is due to the fact some hotkeys do not the same thing as the place menu
> items.
> Therefore we cannot use always \t instead of "<>"
> (It happen each time the command use the mouse position to do something, and
> this is the case in place menu).
> Unless someone knows, with wxWidgets,
> when the same command event is generated by a hot key or by clicking on the
> menu,
> how we know the command event is due to a click on the hot key or click on
> the menu.
> --
> Jean-Pierre CHARRAS
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Attachment: textmate.png
Description: PNG image

Follow ups