kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] better GUI and buttons
On 09/08/2011 11:43 AM, fabrizio wrote:
> The following patch implement the following:
> - fix icon margins in KiCad program icons
> - remove metal background in all icons
> - fix some icons here and there (save button is now the standard one)
> - fix the icons "pcb calculator" and "bitmap2component" in KiCad
> - fixed button image.svg
> - fix a building problem in the icon CMakeLists file
> - some other minor stuff
> after the patch is applied all icons need to be rebuild with:
> cmake ../ -DKICAD_TESTING_VERSION=ON -DCMAKE_BUILD_TYPE=Debug -DMAINTAIN_PNGS=ON
Well this should not technically be true for the following reason:
The bitmaps_png/CMakeLists.txt file is designed to allow folks to build Kicad
and NOT be PNG maintainers. This means the PNG images are already built in our
source tree as *.cpp files.
This means your patch is broken if you think people should be building the
These files are part of the repo, and do not have to be rebuilt, ever, unless
you want to be a maintainer.
So what is wrong with the patch?
1) it did not include the pre-built *.cpp files, according to your own words.