← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] better GUI and buttons

 

Hi,
When you add new svg images you need to modify the CMakeLists.txt
which might (i don't really remember) cause all svg to rebuild.

That maybe is something that we don't want.

just a suggestion
Fabrizio

On Fri, Sep 9, 2011 at 9:12 PM, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> wrote:
> On 9/9/2011 11:13 AM, fabrizio wrote:
>> Dick,
>> you do not have to worry at all. I almost never pay attention to the
>> tone that some e-mails can have. As matter of fact I am not really
>> sure I can get that tone.
>>
>> It is you who need to forgive me if sometimes I do not do the right
>> thing. For me this patch contribution and this png stuff is something
>> very new and sometimes I do not understand very well.
>>
>> Reading all the e-mails we exchanged I think I understand the process.
>> It is just that any time I add an icon and edit the CMakeLists all
>> icons get rebuilt and the patch get massive. All in all this is not a
>> problem for me to add both svg and cpp to the patch.
>
> Fabrizio,
>
> Only the new or modified cpp files get built from the SVG as required.  The
> only reason your last patch rebuilt all of the existing cpp files is that the
> command to create the cpp file changed (transparency) requiring a complete
> rebuild of the cpp files.  Normally only the changed or new SVG files will
> result in the relevant cpp files being changed.  Unless you change or add a lot
> SVGs, the patches should be too large.
>
> Wayne
>
>
>>
>> I have a fresh patch right here that will fix a quite nasty menu
>> problem with eeschema erc menu. I will submit it in a sec.
>>
>> cheers
>> Fabrizio
>>
>> On Fri, Sep 9, 2011 at 3:52 PM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>>> On 09/09/2011 07:41 AM, Wayne Stambaugh wrote:
>>>>
>>>> On 9/9/2011 1:32 AM, Dick Hollenbeck wrote:
>>>>> On 09/09/2011 12:10 AM, Dick Hollenbeck wrote:
>>>>>> On 09/08/2011 11:43 AM, fabrizio wrote:
>>>>>>> Hello,
>>>>>>>
>>>>>>> The following patch implement the following:
>>>>>>> - fix icon margins in KiCad program icons
>>>>>>> - remove metal background in all icons
>>>>>>> - fix some icons here and there (save button is now the standard one)
>>>>>>> - fix the icons "pcb calculator" and "bitmap2component" in KiCad
>>>>>>> - fixed button image.svg
>>>>>>> - fix a building problem in the icon CMakeLists file
>>>>>>> - some other minor stuff
>>>>>>>
>>>>>>> after the patch is applied all icons need to be rebuild with:
>>>>>>> cmake ../ -DKICAD_TESTING_VERSION=ON -DCMAKE_BUILD_TYPE=Debug -DMAINTAIN_PNGS=ON
>>>>>> Well this should not technically be true for the following reason:
>>>>>>
>>>>>> The bitmaps_png/CMakeLists.txt file is designed to allow folks to build Kicad
>>>>>> and NOT be PNG maintainers.  This means the PNG images are already built in our
>>>>>> source tree as *.cpp files.
>>>>>>
>>>>>> This means your patch is broken if you think people should be building the
>>>>>> cpp_26/*.cpp files.
>>>>>>
>>>>>> These files are part of the repo, and do not have to be rebuilt, ever, unless
>>>>>> you want to be a maintainer.
>>>>>> So what is wrong with the patch?
>>>>>>
>>>>>> 1) it did not include the pre-built *.cpp files, according to your own words.
>>>>>>
>>>>>> Dick
>>>>> However, Fabio's commit did rebuild the *.cpp files beforehand.  Nice job Fabio,
>>>>> and the executable find stuff too.
>>>> Dick,
>>>>
>>>> That was me.  I had to disable the stand alone mode you created for development
>>>> purposes since it was killing the Windows build so I figured I might as well
>>>> make sure the required programs were available when the PNG maintainer mode was
>>>> enabled.  Believe it or not, I actually installed Inkscape and pngcrush rebuilt
>>>> the PNGs on Windows.  Maybe someone with OSX can test this to make sure it works.
>>>>
>>>>> Line 556 is still using pngcrush instead of ${pngcrush_EXECUTABLE}
>>>> Oops!  Missed that one.  I'll fix it some time today.
>>>>
>>>> Wayne
>>>
>>>
>>> So the author in the commit should have been "Fabrizio and Wayne" and not Fabio?
>>>
>>> My confusion is real, not troubling at all, and expected given my deteriorating
>>> circumstances, so please excuse me.
>>>
>>>
>>> Thanks Wayne and Fabrizio,
>>>
>>>
>>> Dick
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>


Follow ups

References