← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] - PCBNEW - implement PS plotting width correction.

 

> > Hi, Dick!
> >
> > First of all, i'm not shure my message will be posted in the proper thread :(.
> > Please, be so kind and show me where i can read about interaction with kicad developers mailing list.
> >
> > Let me try to explain some problems of DIY PCB designers and why i suggest the 'width correction` feature (maybe you would like to suggest another feature name). Most of home-made PCB designers take advantages of technologies like toner transfer or photoresit one. They don`t use gerber plots in most cases, because they have no photo-plotters. Usually DIY designers use laser or inkjet printers as PS plotters. The problem is that the final plots has some width errors, especially tracks and pads. For example, my HP LaserJet 2300L enlarges tracks and pads for nearly 0,0025" (0,06 mm). I don't know why, maybe because of rasterization of vector plots? This fact makes almost impossible to produce DIY PCB with modern packages, such as LQFP one (0.25 mm tracks and 0.25 mm clearances).
> > Even if there will be no LaserJet plot errors, there is a track width etching and it is very important for RF PCB designers because of impedance matching.
> >
> > Thank you very much and sorry for my english,
> > Alexander.
>
> Thank you.
>
> Committed in rev 3342. Please verify it still works as intended, since the patch was
> applied to a version later than the patch was made for.
>
> Sorry for the delay. I was busy on some other changes myself.
>
> This was one of the better patches coming in from first time contributors.
>
> Thanks again.
>
> Dick
>
> P.S. there were some blank lines with spaces on them. Trailing blanks are not desirable,
> so please check your editor's settings and try and remove them.
>

 Hi, Dick!

I'm very glad to see 'width correction' patch merged upstream!
But for some reason, part of the code was not included. Namely the overrided virtual functions of inherited class PS_PLOTTER.
This typo makes 'width correction' patch quite useless :(. The solution is in attachment.

Thanks!
Alexander.
=== modified file 'include/plot_common.h'
--- include/plot_common.h	2012-01-07 06:02:38 +0000
+++ include/plot_common.h	2012-01-07 10:57:31 +0000
@@ -362,6 +362,16 @@
         plot_scale_adjX = scaleX;
         plot_scale_adjY = scaleY;
     }
+ 
+    virtual void set_plot_width_adj( double width )
+    {
+        plot_width_adj = width;
+    }
+    
+    virtual double get_plot_width_adj()
+    {
+        return plot_width_adj;
+    }
 
     virtual void set_viewport( wxPoint aOffset, double aScale, bool aMirror );
     virtual void rect( wxPoint p1, wxPoint p2, FILL_T fill, int width = -1 );


Follow ups