← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] Floating tracks loose netcode fix

 

Yes, it wasn't the latest. I'll try to fix this.

On Feb 17, 2012 8:45 PM, "jean-pierre charras" <jp.charras@xxxxxxxxxx>
wrote:
>
> Le 09/02/2012 17:04, Dick Hollenbeck a écrit :
>
>> Janis
>>
>> 1) This PATCH is going to take some time to process, it will require
some discussion.  In
>> any case it is not conformant to coding standards as is but it is not a
large patch so I
>> would not bother resubmitting it yet.
>>
>> 2) you will have to join the mailing list to continue posting.
>>
>>
>
> Janis,
> First, thanks for your patch.
> I am thinking you have not used the latest kicad version (i.e. the
testing version.) so it is hard to test your patch.
>
> Remember you *should* use only latest sources, because if not, we are
unable to use a patch.
> see:
> https://code.launchpad.net/kicad
> to download latest sources.
>
> Mainly pcbnew/connect.cpp has a major change in connections calculations,
> and does not need anymore a track ends on the center of a pad to be seen
as connected.
>
> I believe your patch does not use this version.
>
> I encourage you to resubmit a patch using the latest sources.
>
> Thanks.
>
> --
> Jean-Pierre CHARRAS
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp

Follow ups

References