kicad-developers team mailing list archive

[lajos kamocsay <panka.nospam@xxxxxxxxx>]

Hi Dick--


Thanks for taking looking at it.

When I worked on this, I looked at the mose wheel + [ctrl | shift]
behavior, which (at least in my build) was also limited to the scroll
bar length. I agree with you however that removing that limit would
work better, I can certainly take a crack at it.


Thanks-
-lajos



On Thu, Mar 22, 2012 at 3:45 PM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
> lajos,
>
> Just tried the patch.
>
> Seems to work well up until you hit a scroll bar travel limit, at which point the pointer
> slips relative to the dragging drawing.  I found this disconcerting.
>
> Is it desirable and easy to make it work such that the pointer freezes its directional
> travel on the axis or axes which have hit a travel limit?
>
> It would be nice to try that mode.  I think that as soon as you put the user in control
> with the middle mouse button, you have to honor the "attachment" that has been made with
> the mouse to the drawing during the panning.  If you hit a travel limit, this is no reason
> to allow the mouse to continue to move.  My first impression was that this was an
> unnatural response.
>
> Think about this.
>
> Dick
>
>
>
>
>
> On 03/17/2012 09:07 AM, lajos kamocsay wrote:
>> Hello Dick-
>>
>>
>> Sorry, totally missed the tab setting in my editor.
>> Attached is the patch with the tabs removed.
>>
>> Note however that the files generated by wxformbuilder do have tabs:
>>
>>  eeschema/dialogs/dialog_eeschema_options_base.cpp
>>  pcbnew/dialogs/dialog_general_options_BoardEditor_base.cpp
>>
>> I checked other wxformbuilder files and those have tabs also, so this
>> is probably ok. If you need me to convert those, let me know.
>>
>>
>> Thanks-
>> -lajos
>>
>>
>>
>> On Sat, Mar 17, 2012 at 12:24 AM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>>> Thanks lajos.
>>>
>>> Someone else is going to have to look at this one.
>>>
>>> But please do them a favor before they start:
>>>
>>> 1) Fix your tabs, make them 4 spaces.  Tabs are not allowed in KiCad source code.
>>>
>>> 2) After fixing, send your patch as an attachment, not inline.
>>>
>>> Whoever reviews it may have more to say.
>>>
>>> Dick
>>>
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>> _______________________________________________
>>> Mailing list: https://launchpad.net/~kicad-developers
>>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~kicad-developers
>>> More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp