kicad-developers team mailing list archive

[Dick Hollenbeck <dick@xxxxxxxxxxx>]

On 04/11/2012 05:47 AM, jean-pierre charras wrote:
> Le 10/04/2012 18:31, Dick Hollenbeck a écrit :
>> I updated this to support the PCBNEW nanometers.
>>
>> Might have broken something on the non-nanometer build, did not test that.
>>
>>
>>
>> Also, Jean-Pierre,
>>
>> I think there is still some incompatibility in the zone hatches.  There may be too many of
>> them being constructed.
>>
>> Might want to instrument the perimeter crosshatch line building code with some printf()s
>> and see how many are being built in both compile modes.
>>
>> There is a lot of CPU cycles being burned in crosshatch line drawing from what I can tell.
> I fixed this.

Fantastic!  Thanks for that.  Now folks can help us find problems with this compile mode.


> I also moved in convert_to_biu.h the function DMils2iu( int dmils ),
> and added a new function Mils2iu( int mils ),
> because we have *a lot* of constant values (in decimil and sometimes mils)
>   in constructors and dialogs we need to convert to new units.
> I am thinking all these values should be converted using one of these functions, and never assigned
> using something like:
> #if defined( USE_PCBNEW_NANOMETRES )
>      ...
> #else
>      ...
> #endif

Agreed, that will help read-ability in the core source code.  Also, we may actually get
some patches from folks as they help find problems in the nanometer compile mode, because
often it is simply a matter of using one of these new functions.


> So if we have issues with nanometers, it will be more easy later to modify pcbnew.
>
> Also these functions could be useful in Cvpcb and Gerbview (in export to pcbnew functions)
>
>