kicad-developers team mailing list archive
Mailing list archive
Re: [PATCH] PcbNew Block and Module Rotate
On Mon, Jun 04, 2012 at 09:07:25AM +0200, jean-pierre charras wrote:
> You can already easily rotate a module by any angle, in module properties dialog.
Altough pads are drawn, not flashed :( need to implements AM generation
> 1 - Only 90 degrees rotations can be undone by -90 degrees rotations.
> In other cases rounding issues create a small offset (cumulative after some undo/redo) and coordinates change.
> When rotating by any angle but 90, items should be seen as modified.
Aren't edits undone replaced with a copy of the original object (like in
> 2 - You are using a global variable only to pass a parameter. This is bad.
Burn him at the stake XD
> 3 - Rotation angle is in degrees and is an int. Why ?
> the internal resolution is 0.1 degree and will be perhaps increased.
I'd use a decidegree as an int.