kicad-developers team mailing list archive

[Miguel Angel <miguelangel@xxxxxxx>]

Sorry, I replied Wayne only.

I will review my coding style for cmake files too before any next commits. Sorry about that.

Enviado desde un móvil 

Inicio del mensaje reenviado:

> De: Miguel Angel <miguelangel@xxxxxxx>
> Fecha: 12 de enero de 2013 21:05:16 GMT+01:00
> Para: Wayne Stambaugh <stambaughw@xxxxxxxxxxx>
> Asunto: Re: [Kicad-developers] Python scripting cmake build macros.
> 
> Thanks Wayne! It sounds superb, I tried to fix the rt problem, and got nowhere.. That means that you finally managed to build a windows pyd&pcbnew with scripting?
> 
> Also the python2 thing was mine, mainly because I didn't find the cmake function to search for the python interpreter which is just perfect. Where did you find it? (I promise I read the cmake manual several times) :)
> 
> Thanks for the fix!!
> 
> Enviado desde un móvil
> 
> El 12/01/2013, a las 18:15, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> escribió:
> 
>> I've been attempting to resolve my Python scripting build issues on MinGW32 on Windows and I have a few questions for the folks who wrote the cmake build code.  Why are we not using cmake's FindPythonInterp() instead of specifying the python executable on the path?  Specifying the Python interpreter on the command line at build time seems unnecessary to me.  CMake's FindPythonInterp supports defining a a specific version of Python by defining Python_ADDITIONAL_VERSIONS.  I'm guessing we would want to do that because python2 is currently defined as the default Python interpreter so I'm also assuming that the scripting code generated does not work with Python3.
>> 
>> There is also a link bug on MinGW because rt is defined as one of the link libraries in SWIG_LINK_LIBRARIES.  Actually, someone attempted to fix it by adding and conditional statement to only add rt on Linux but they forgot to take it out of the original list.
>> 
>> For future reference the indentation level for CMake files is 4 spaces and CMake statements should be lower case.
>> 
>> If no one objects, I will fix these issues which should make the Python scripting builds more reliable.
>> 
>> Thank you for all your efforts in bringing scripting to KiCad.
>> 
>> Wayne
>> 
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp