← Back to team overview

kicad-developers team mailing list archive

Re: patch: pcbnew printing "Fit to page" scale fix


Le 11/03/2013 22:39, Sergey Borshch a écrit :
Sorry, mistype again. Fixed.

On 11.03.2013 23:36, Sergey Borshch wrote:
On 11.03.2013 21:41, jp charras wrote:
Le 11/03/2013 15:17, Sergey A. Borshch a écrit :
This patch makes scale option "fit to page" do the same as in all
other programs worldwide - produce biggest image that still fits to
 Pcbnew generates 1:1-scaled centered image instead.

Sorry, your patch does not work:
- scale is evaluated as int, not double.
- page margins are not taken in account.
- crashes with void boards.

Yes, you're right, my fault.

   reworked patch attached.

Thanks for quick response and commiting other my patches.


Committed in rev 3997, with many other minor fixes in print dialog.

Jean-Pierre CHARRAS