kicad-developers team mailing list archive

[Carl Poirier <carl.poirier.2@xxxxxxxxx>]

Great, thanks for the update. I'm glad it will be useful for at least some
time.

On Monday, March 18, 2013, Wayne Stambaugh wrote:

> On 3/18/2013 9:40 AM, Carl Poirier wrote:
> > Hi Wayne,
> >
> > Please let me know why it fails to apply. The last one with suffix 8
> > will probably fail as well because the only new changes are coding style
> > fixes.
> >
> > On my side, I made sure everything is alright with the latest revision
> > doing the following:
> >
> > bzr branch lp:kicad kicad_carl
> > cd kicad_carl
> > bzr merge cmp_and_mod_display_library_8.patch
> > mkdir build; cd build
> > cmake ../ -DKICAD_TESTING_VERSION=ON -DCMAKE_BUILD_TYPE=Debug
> > make
> >
> > And then I tested everything with one of my projects as well as a new
> > one. I believe I did not miss anything in regard to verifying the
> > functionality in the latest revision, but I'm new to bazaar (using hg
> > and svn) so I guess I may have forgot something.
> >
> > That being said, I understand the priority should be put to the fp lib
> > changes.
> >
> > Carl
>
> I applied the patch and compiled it last night and everything went fine.
>  You patch will not be disruptive to my footprint library table work
> since it only adds the library name to a separate column in the
> component/footprint list box.  It has no impact on the way components
> and footprints are selected.  I do want to let you know that at some
> point in the future, all of this will probably go away and a more
> unified method for selecting components and footprints will be
> implemented.  Until then, you patch is useful in that it lets the use
> know what library the component/footprints came from.  Thank you for
> your interest in helping KiCad.
>
> Dick, if you want to commit this patch, go ahead.  Otherwise, I will
> commit it this evening.
>
> >
> > On Sunday, March 17, 2013, Wayne Stambaugh wrote:
> >
> >     On 3/17/2013 9:07 PM, Wayne Stambaugh wrote:
> >
> >         On 3/17/2013 4:52 PM, Dick Hollenbeck wrote:
> >
> >             Wayne,
> >
> >             We need your approval, no or no go.
> >
> >             We can also table it somewhere until the fp lib table smoke
> >             clears.
> >
> >
> >         I just tried to apply this patch and it failed against r4017.
> >          The last
> >         version I have of this patch had a suffix of 6.  I did take a
> >         look at it
> >
> >
> >     I just checked the mailing list and saw that the patch is up to
> >     suffix 8.  I must have missed it.  I'll try to test it tomorrow.
> >
> >         and it I may hold off until the footprint table code is ready.
>  The
> >         reason being is it may add confusion to the library ordering
> issue.
> >         Users may think that they can now safely select a footprint or
> >         component
> >         with a duplicate without regard to library ordering which could
> >         cause
> >         more confusion than we already have on this issue.  The other
> >         problem
> >         will be that this dialog is used for both Eeschema and Pcbnew so
> >         we may
> >         to tweak it to handle both the current library path sort order
> >         and the
> >         footprint library table methods.  I suppose I could create a new
> >         dialog
> >         for selecting footprints using the footprint library table and
> >         keep the
> >         current dialog for selecting components in Eeschema until we get
> >         the new
> >         file format and SWEET implemented.  I would like to apply this
> >         patch and
> >         test it's behavior before I give it the OK.
> >
> >
> >             On Mar 17, 2013 12:09 PM, "Carl Poirier"
> >             <carl.poirier.2@xxxxxxxxx
> >             <mailto:carl.poirier.2@xxxxxxxxx>> wrote:
> >
> >                 By the way, uncrustify was telling me about unknown
> >             symbols which I
> >                 believe may be some mistake on my side, so I just
> >             commented out the
> >                 lines in the aformentioned tool to get it to work. I
> >             forgot to
> >                 remove them before creating the patch though so just
> >             ignore this
> >                 change or look at this one instead!
> >
> >                 Carl
> >
> >                 On Sun, Mar 17, 2013 at 1:04 PM, Carl Poirier
> >                 <carl.poirier.2@xxxxxxxxx
> >             <mailto:carl.poirier.2@xxxxxxxxx>> wrote:
> >
> >                     I found a few other kinks in the coding style of the
> >             patch using
> >                     the checkcoding.py tool from Miguel and made sure it
> >         >             _________________________________________________
> >                                 Mailing list:
> >
> >             https://launchpad.net/~kicad-__developers
> >             <https://launchpad.net/~kicad-developers>
> >
> >             <https://launchpad.net/%__7Ekicad-developers
> >             <https://launchpad.net/%7Ekicad-developers>>
> >                                 Post to     :
> >             kicad-developers@xxxxxxxxxxxxxxxxxxx <javascript:;>
> >
> >             <mailto:kicad-developers@xxxxxxxxxxxxxxxxxxx <javascript:;>>
> >                                 Unsubscribe :
> >
> >             https://launchpad.net/~kicad-__developers
> >             <https://launchpad.net/~kicad-developers>
> >
> >             <https://launchpad.net/%__7Ekicad-developers
> >             <https://launchpad.net/%7Ekicad-developers>>
> >                                 More help   :
> >             https://help.launchpad.net/__ListHelp
> >             <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> >
> >
> >
> >             _________________________________________________
> >             Mailing list: https://launchpad.net/~kicad-__developers
> >             <https://launchpad.net/~kicad-developers>
> >             Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx<javascript:;>
> >             Unsubscribe : https://launchpad.net/~kicad-__developers
> >             <https://launchpad.net/~kicad-developers>
> >             More help   : https://help.launchpad.net/__ListHelp
> >             <https://help.launchpad.net/ListHelp>
> >
> >
> >
> >
> >     _________________________________________________
> >     Mailing
> >
>
>