kicad-developers team mailing list archive

[Hans Henry von Tresckow <hvontres@xxxxxxxxx>]

On Tue, Apr 23, 2013 at 4:53 AM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:

> Good catch.  Probably it was me that added the vendor prefix and possibly
> broke the renaming for that template at that time.  I would like to keep
> the vendor prefix.  (Ti has recently changed its product name on that cpu
> series, but is retaining stellaris name only for this particular host
> board. So confusion is on its way.)
>
> I can do the fix in 6 minutes after we agree what it is.
>
> Is this a code change or a filename or dir change in your opinion?
> On Apr 23, 2013 1:23 AM, "Hans Henry von Tresckow" <hvontres@xxxxxxxxx>
> wrote:
>
>>
>>
>>
>> On Wed, Apr 10, 2013 at 11:17 PM, Dick Hollenbeck <dick@xxxxxxxxxxx>wrote:
>>
>>> In my testing I was always choosing the overwrite existing pro file
>>> execution path.
>>>  On Apr 10, 2013 5:16 PM, "Brian Sidebotham" <brian.sidebotham@xxxxxxxxx>
>>> wrote:
>>>
>>>> The latest 4090 appears to work the same. I'll have to test on Linux,
>>>> because maybe there is some difference there.
>>>>
>>>> Best Regards, Brian.
>>>>
>>>>
>>>> On 10 April 2013 22:39, Brian Sidebotham <brian.sidebotham@xxxxxxxxx>wrote:
>>>>
>>>>>
>>>>> On 10 April 2013 20:49, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:
>>>>>
>>>>>> Brian,
>>>>>>
>>>>>> a) I fixed bugs related to use of KICAD_PTEMPLATE environment
>>>>>> variable.  Iterminate it with SEP() now if
>>>>>> not set that way, necessary for use of common code in TAB creation.
>>>>>> Probably never tested before I stumbled onto it.
>>>>>>
>>>>>> (I am not allowed to use KiCad, only fix it, or so it seems lately.)
>>>>>>
>>>>>>
>>>>>> b) Updated kicad.odt to reflect proper spelling of that environment
>>>>>> variable.
>>>>>>
>>>>>>
>>>>>> c) updated header file where doxygen will grab that same spelling,
>>>>>> previously erroneously spelt, also missing P.
>>>>>>
>>>>>>
>>>>> Hi Dick,
>>>>>
>>>>> I've just grabbed the kicad docs. Ashamedly I didn't have them before
>>>>> now! I didn't know the project templates had been documented. It was on my
>>>>> TODO list.
>>>>>
>>>>>
>>>>>>
>>>>>> d) question why we are copying the *.pro file when one is being
>>>>>> created.  I end up with two *.pro files in the same directory, one
>>>>>> from the template dir and the one being created which has a different
>>>>>> basename.
>>>>>>
>>>>>>
>>>>>> e) question why we are not renaming basename of cloned files to the
>>>>>> basename of new project.
>>>>>>
>>>>>>
>>>>>>
>>>>>> d) and e) are solicitations of your opinion.
>>>>>>
>>>>>
>>>>> d) and e) are both incorrect (and changed) behaviour if that is the
>>>>> case.
>>>>>
>>>>> I've just tested with build 3957 which appears to work correctly for
>>>>> me according to the documentation anyway. I'll compile the latest and try
>>>>> again with the raspberry-pi template.
>>>>>
>>>>> Best Regards, Brian.
>>>>>
>>>>>
>>>>
>>>
>> I think I might have figured out the problem. It looks like thefiles int
>> the  ti-steallaris-boosterpack40 template are named boosterpack40.* and not
>> ti-stellaris-boosterpack40.*. I renamed the folder to boosterpack40 and the
>> renaming seems to work now.
>>
>> Two questions:
>> 1) Which is the perefered naming convetion here?
>> 2) What would be the best way to submit a patch for this?
>>
>> Thanks,
>> --
>> Henry von Tresckow (hvontres)
>>
>
I think the vendor prefix is a good idea, so I think a file rename would be
the best option here. In that case, the ti-stellaris-boosterpack40_min
template also would need renaming.

Thanks for all of the good work :)

-- 
Henry von Tresckow (hvontres)