← Back to team overview

kicad-developers team mailing list archive

Re: [PATCH] - Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()

 

On Sun, Jun 9, 2013 at 11:05 AM, Dick Hollenbeck <dick@xxxxxxxxxxx> wrote:

> On 06/08/2013 07:08 PM, Chris Morgan wrote:
> > I'm still not sure how to generate patches with bzr. I really want to do
> 'bzr format-patch
> > -1' like with git but I can't find an equivalent approach.
> >
> > ------------------------------------------------------------
> > revno: 4196
> > committer: Chris Morgan<chmorgan@xxxxxxxxx <mailto:chmorgan@xxxxxxxxx>>
> > branch nick: kicad
> > timestamp: Sat 2013-06-08 16:50:48 -0400
> > message:
> >   Implement auto panning while moving in EDA_DRAW_PANEL::OnMouseEvent()
> >
> >   Fixes an issue where EDA_DRAW_PANEL::OnMouseLeaving() isn't called
> when the mouse leaves
> > via the lower right
> >   or lower bottom edges.
>
>
> Can you elaborate on the exact user operations that exhibit the bug
> please.  Assume the
> guy doing it not a programmer for example.  Show us the bug.
>
>
> Thanks,
>
> Dick
>


Of course. Apologies for being unclear. I hope this is explains things but
please let me know and I can try to improve upon it.

- Start pcbnew
- Preferences -> General and enable 'Pan while moving object'
- Open a board file with parts and traces
- Left click and drag to grab a few parts/traces
- Move the parts around to the right or bottom edges and notice that the
view doesn't always pan, maybe wx isn't considering the mouse leave until
the cursor leaves the scroll bar?
- Move the parts around to the left or top and notice the view almost
always pans.

The change puts a border around the view of 5% of the width that means that
the panning works consistently on all borders. Panning when the cursor gets
near the view borders also makes it easier to visually follow the panning.

I was looking at animating the panning to make it even easier to follow but
I'm not sure if this would be either easy or all that helpful but even a
fast pan (200ms or so) would make it a lot easier for the eye to track. I'm
used to eaglecad. Looking at using kicad as a replacement and figured I
could show my appreciation for a great tool by helping fix some bugs. Kicad
code is easy to follow and easy to build. The only confusing part for me is
bzr.

Chris









>
>
>
>
> >
> >   Adjustable margin causes panning to happen when the cursor enters the
> margin area.
> > Margin percentage is
> >   currently set to 5% of the window height or width.
> >
> >   Margin can be adjusted to cause panning to occur closer to the center
> of the window,
> > making it easier for
> >   the user to visually track the panning event.
> > ------------------------------------------------------------
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~kicad-developers
> > Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~kicad-developers
> > More help   : https://help.launchpad.net/ListHelp
> >
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>

Follow ups

References