kicad-developers team mailing list archive

[Carl Poirier <carl.poirier.2@xxxxxxxxx>]

Hi guys,

If you want to put your efforts on some more important and complex tasks, I
can surely volunteer to take care of it, if it has not been done already.
I'll attach the patch once I'm done going over all the code.

Carl

On Sun, Aug 4, 2013 at 1:55 PM, Wayne Stambaugh <stambaughw@xxxxxxxxxxx>wrote:

> On 8/3/2013 7:13 PM, Cirilo Bernardo wrote:
>
>> ----- Original Message -----
>>
>>  From: Wayne Stambaugh <stambaughw@xxxxxxxxxxx>
>>> To: kicad-developers@lists.**launchpad.net<kicad-developers@xxxxxxxxxxxxxxxxxxx>
>>> Cc:
>>> Sent: Sunday, August 4, 2013 4:59 AM
>>> Subject: Re: [Kicad-developers] USE_PCBNEW_NANOMETRES
>>>
>>> On 8/3/2013 2:52 PM, Dick Hollenbeck wrote:
>>>
>>>>
>>>>   Can any one see a reason not to yank this conditional, and make its
>>>> enabled
>>>>
>>> code the norm?
>>>
>>> I can't think of one.  Now as good a time as any.  Hopefully no one is
>>> still building KiCad with USE_PCBNEW_NANOMETRES=OFF.
>>>
>>>
>>
>> Is it worthwhile forcing a CMake error if someone does define it off?
>>
>
> I think this was written with the intention of removing it completely from
> the code once nanometer support was stable.  Getting rid of all of the ugly
> #if define(USE_PCBNEW_NANOMETRES)/**#endif from the source code should be
> the goal so making CMake force an error wouldn't server any purpose.
>
>
>> - Cirilo
>>
>>
>>>>   It seems as good as old school now.
>>>>
>>>>   Dick
>>>>
>>>>
>>
>
> ______________________________**_________________
> Mailing list: https://launchpad.net/~kicad-**developers<https://launchpad.net/~kicad-developers>
> Post to     : kicad-developers@lists.**launchpad.net<kicad-developers@xxxxxxxxxxxxxxxxxxx>
> Unsubscribe : https://launchpad.net/~kicad-**developers<https://launchpad.net/~kicad-developers>
> More help   : https://help.launchpad.net/**ListHelp<https://help.launchpad.net/ListHelp>
>