kicad-developers team mailing list archive

[Maciej Suminski <maciej.suminski@xxxxxxx>]

Hi Lorenzo,

Good that we are getting a peer review, I counted on that after merging 
the branch. I think you are right, variable names should be in headers 
too - if you have not already changed that, then I am going to do it 
tomorrow.
Regarding LAYER_NUMs, if all the code uses LAYER_NUMs, then I do not see 
a point in changing that in the contributed part. Again, if you have 
ready patches and main developers agree, please go ahead. If you do not 
want to spend time on that, then I will take care of introducing the 
changes.

Regards,
Orson

W dniu 2013-10-31 21:36, Lorenzo Marcantonio pisze:
> I'm LAYER_NUMizating the state of the art imported contributions, i.e.
> mostly replacing ints with LAYER_NUM.
>
> Found a sad thing indeed: in pcb_painter.h we have prototypes like:
>
>   virtual bool Draw( const VIEW_ITEM*, int );
>
> IMHO argument names would be useful in the header files:P And, by the
> way, that int is a layer number...
>
> Is that wanted? Some kind of new C++ coding style? At least there is
> a @copydoc referring back to the parent class, however it's very
> unconvenient to go find it to read the complete declaration...