kicad-developers team mailing list archive

[Marco Serantoni <marco.serantoni@xxxxxxxxx>]

Nick,
I’ve listened your complain about the wrong result in version.h and therefore in the kicad application title when you checkout a previous revision of the code.
I personally found your patch functionally correct, if no one will disregard in the next days with your patch I think we could proceed to use it.

Thank your for your contribution,

—
Marco


On 25/dic/2013, at 01:27, Nick Østergaard <oe.nick@xxxxxxxxx> wrote:

> 
> Hello Marco
> 
> I have made a proposed patch for the revision number generated by the cmake scripts. Here attached.
> 
> Background information:
> The current cmake scripts that generate the bzr revision number to be displayed in the version info in kicad showed only the (HEAD) revision of the repository, and not the working tree. This is not any good if one tries to checkout an older version and build and then forgets what he has build.
> 
> I have modified such that it grabs the tree version, which is the version checked out with bzr update -r1337 or whatever revision you are interrested in.
> 
> I am new to cmake, so patch might not be ideal, but it works!
> 
> Nick Østergaard
> <bzr-revno.patch>