← Back to team overview

kicad-developers team mailing list archive

Re: various patches

 

On 1/1/2014 10:27 PM, Cirilo Bernardo wrote:
> Hi folks,
> 
>  I have put two sets of patches onto github for anyone to review or apply.
> 
> The (bzr) patches:
>   export_idf3.patch :  Adds basic IDF3 export (board and cutouts / holes only)
> 
>   export_vrml.patch : Improved VRML export; includes more realistic coloring scheme, zone fills, improved eye candy. This patch is better than the patch I previously posted here; this patch fixes a number of bugs, eliminates a redundant class, and provides features such as the zone fills and silver pads.
> 
> URL: https://github.com/cbernardo/kicad-patches
> 
> The patches are against Rev 4598.
> 
> I would appreciate any comments on the patches.  Personally I would like to see the patches incorporated with the bzr source. The vrml patch includes a major rewrite of export_vrml.cpp and I'm confident users will find the results to their liking.
> 
> - Cirilo
> 

Cirilo,

Your IDF3 patch fails to build on MinGW (runtime version 3.20, w32api
version 3.17, and gcc version 4.7.2) due to undefined reference to
localtime_r().  I suggest that you use wxDateTime to build your header
time stamp instead of the the time_t and tm structures.  This should
ensure that your code works on all platforms.

Thanks,

Wayne



Follow ups

References