kicad-developers team mailing list archive

[Sean Silva <chisophugis@xxxxxxxxx>]

On Sat, Feb 15, 2014 at 6:27 AM, Fabrizio Tappero <
fabrizio.tappero@xxxxxxxxx> wrote:

> Hello,
> is there any chance we can push this patch?
>

It was included in <
http://bazaar.launchpad.net/~kicad-product-committers/kicad/product/revision/4685>.
Actually, I was going to ask if it was common to include patches without
attribution like this (generally, it's good open source practice to make
sure all patches have proper attribution in the version control log).

-- Sean Silva


>
> Best regards
> Fabrizio
>
>
>
> On Wed, Feb 12, 2014 at 1:46 AM, Sean Silva <chisophugis@xxxxxxxxx> wrote:
>
>>
>>
>>
>> On Tue, Feb 11, 2014 at 1:37 PM, jp charras <jp.charras@xxxxxxxxxx>wrote:
>>
>>> Le 11/02/2014 00:13, Sean Silva a écrit :
>>> > Hi, first time posting. Trivial patch attached fixing a header guard.
>>> >
>>> > Clang's -Wheader-guard warning caught this.
>>> >
>>> >
>>> > I apologize for the git-format-patch style patch (might need to pass
>>> > `-p1`). I spent about an hour or two trying to find a workable workflow
>>> > with bzr but wasn't able to find one. Skimming the archives it seems
>>> > like there is discussion about moving to git from bzr; hopefully this
>>> > can provide a data point for the discussion (I'd be glad to provide
>>> more
>>> > info it you're interested about what the main things I ran up against
>>> > were, how far I got working with bzr, etc.).
>>> >
>>> > -- Sean Silva
>>>
>>> No problem for the git-format-patch style.
>>> I committed you fix in the last commit.
>>>
>>
>> Thanks.
>>
>> -- Sean Silva
>>
>>
>>>
>>> Thanks.
>>>
>>> --
>>> Jean-Pierre CHARRAS
>>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>