kicad-developers team mailing list archive

[Sean Silva <chisophugis@xxxxxxxxx>]

Did you mean to include the changes to HOW_TO_CONTRIBUTE.txt in this patch?
Those changes seem unrelated.


On Wed, Feb 19, 2014 at 6:52 AM, Fabrizio Tappero <
fabrizio.tappero@xxxxxxxxx> wrote:

> Hello guys,
> thank you Sean for the feedback. In attachment the reviewed patch.
>
> Please consider for mainstream build.
>
> Best regards
> Fabrizio
>
>
> On Sun, Feb 16, 2014 at 1:19 AM, Sean Silva <chisophugis@xxxxxxxxx> wrote:
> > Here are some things I noticed on a closer reading:
> >
> > -    _( "Place a hierarchical label. This label will be seen as a
> > hierarchical pin in the sheet symbol" )
> > +    _( "Place a hierarchical label. This label will be seen as
> hierarchical
> > pin in the sheet symbol" )
> >
> > The second sentence here becomes "broken" when the article is omitted.
> For
> > consistency with the other menu items, the article should probably be
> > omitted in the first sentence though.
> >
> > -    _( "Import the footprint selection from CvPcb (the .cmp file)\n\
> > -in component footprint fields" )
> > +    _( "Back-import component footprint fields via CvPcb .cmp file" )
> >
> > Is "back-import" standard terminology? (sorry, I'm pretty new to Kicad).
> >
> > -                 _( "Open an existing schematic project" ),
> > +                 _( "Open an existing schematic sheet" ),
> >
> > Is "schematic sheet" the same thing as "schematic project"? If not, then
> > this changes the meaning.
> >
> > -    btn->SetToolTip( _( "Eeschema (Schematic editor)" ) );
> > +    btn->SetToolTip( _( "Eeschema - Electronic schematic editor)" ) );
> >
> > Unmatched parenthesis in the string.
> >
> > -- Sean Silva
> >
> >
> >
> > On Thu, Feb 13, 2014 at 7:58 PM, Fabrizio Tappero
> > <fabrizio.tappero@xxxxxxxxx> wrote:
> >>
> >> Thanks Sean,
> >> would you be kind enough to suggest any improvements if any is needed.
> >> If not I'd like to ask somebody to push this patch in the main stream
> >> so that I start working on Cvpcb and other apps.
> >>
> >> thanks
> >> Fabrizio
> >>
> >>
> >> On Fri, Feb 14, 2014 at 12:42 AM, Sean Silva <chisophugis@xxxxxxxxx>
> >> wrote:
> >> > I'm not an expert in menu item usability, but I am a native English
> >> > speaker.
> >> > These labels/entries seem like a nice improvement over the existing
> >> > ones.
> >> >
> >> > -- Sean Silva
> >> >
> >> >
> >> > On Wed, Feb 12, 2014 at 12:45 PM, Fabrizio Tappero
> >> > <fabrizio.tappero@xxxxxxxxx> wrote:
> >> >>
> >> >> Hello,
> >> >> I tried to adjust the KiCad and eeschema menu entries and labels
> >> >> following
> >> >> a little how a gui program normally is. It would be great if this
> patch
> >> >> could be reviewed by e native English speaker who is a little
> familiar
> >> >> with
> >> >> menu entry usability. (e.g better to say "KiCad User Manual" instead
> of
> >> >> "Help" or "Manual")
> >> >> I have tried to shorten button hints making them more direct and
> >> >> without
> >> >> articles like "Insert Pin" instead of "Insert a Pin".
> >> >>
> >> >> If we can find some consensus, I will work on pcbnew and other gui
> too.
> >> >>
> >> >> thank you
> >> >> Fabrizio
> >> >> PS the accellerator for the kicad and eeschema user manual Ctrl-H
> does
> >> >> not
> >> >> seem to work for me (but it might be a linux thing)
> >> >>
> >> >> _______________________________________________
> >> >> Mailing list: https://launchpad.net/~kicad-developers
> >> >> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> >> >> Unsubscribe : https://launchpad.net/~kicad-developers
> >> >> More help   : https://help.launchpad.net/ListHelp
> >> >>
> >> >
> >
> >
>