← Back to team overview

kicad-developers team mailing list archive

Re: PATCH: Component chooser now with thumbnail image of the component. And Unit select.

 

On 2/19/2014 1:14 AM, Henner Zeller wrote:
>> I have a few comments and one minor bug.  On windows builds with
>> wxWidget 3.0.0, the component view panel does not update when a new
>> component is selected.  When the dialog is closed and reopen it, then
>> the selected component is shown correctly.
> 
> This should hopefully be now fixed with the latest patch; it improves
> redraws as suggested by jp.

Redraw works correctly now.

> 
>> I could not open the dialog fbp file with wxFormBuilder 3.4.0 or 3.3.04.
>>  I got an error saying that the dialog was created with a newer version
>> of wxFormBuilder.  What version of wxFormBuilder are you using and if
>> it's greater than 3.4.0 where did you get it?  The latest version on the
>> wxFormBuilder website is 3.4.0.
> 
> I checked my version now: it is 3.4.2. Maybe I should downgrade to be
> compatible with you guys ?

That would be helpful.  Otherwise, the rest of us will not be able to
make changes to your dialog.  Your suggestion of altering the minor
revision number worked.  I successfully opened the fbp file with 3.4.0
but there could be some missing features that I missed.

> 
>> One minor comment on your dialog layout, take a look at some of the
>> layout space in some of the other dialogs.  The dialog buttons do not
>> have enough padding between them and the dialog frame.
> 
> How can I add the spacing to the frame ? I attempted to put everything
> in a wxBoxSizer giving it a border of 12, but it did't make any
> difference. What is the trick to get this going in wxformbuilder ?

Select the control you want to add padding and select either the wxALL
flag if you want to pad all 4 sides of the control or wxLEFT, wxRIGHT,
wxTOP, and/or wxBOTTOM if you have specific padding requirements.
Padding is cumulative.  If you have two vertically aligned controls with
the border set to 5 (default) and wxALL, the padding between the two
controls will be 10.  One of the easiest ways to get a feel for how the
sizers work in wxWidgets is to download the wxPython demo and play
around with the various sizer demos.  I know you are not a Python fan
but it's faster and easier than building the sizer demo included in the
wxWidgets source.

> 
> -h
> 



References