kicad-developers team mailing list archive

[Henner Zeller <h.zeller@xxxxxxx>]

On 22 February 2014 17:13, Henner Zeller <h.zeller@xxxxxxx> wrote:
> Looks like jp already changd that part by using _("Unit "); though I
> am not sure if the space should be part of the translated text.

Ah, no, wait, his patch actually broke the build, and Cirilo's patch fixes it.

>
> On 22 February 2014 15:21, Wayne Stambaugh <stambaughw@xxxxxxxxxxx> wrote:
>> On 2/22/2014 4:55 PM, Cirilo Bernardo wrote:
>>> In the last commit there was a strange string concatenation which
>>> would not build on my machine:
>>>
>>> _("Unit") + wxT( " " ) + unitName
>>>
>>>
>>> This patch breaks the operation into 2 steps, first defining the
>>> wxString "Unit " and concatenating the name.
>>>
>>> - Cirilo
>>>
>>
>> Cirilo,
>>
>> Are you building with wxWidgets 2.8?  I'll commit this patch but I need
>> a little more substance for the commit message.
>>
>> Thanks,
>>
>> Wayne
>>
>>
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~kicad-developers
>> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~kicad-developers
>> More help   : https://help.launchpad.net/ListHelp