kicad-developers team mailing list archive

[Wayne Stambaugh <stambaughw@xxxxxxxxxxx>]

On 2/22/2014 5:53 PM, Martin Janitschke wrote:
> Heyho,
> there are currently two reports with different wrl files causing the
> 3d-viewer to crash at different places.
> The reports are:
> https://bugs.launchpad.net/kicad/+bug/673603 and
> https://bugs.launchpad.net/kicad/+bug/804778 .
> 
> The patch
> https://bugs.launchpad.net/kicad/+bug/804778/+attachment/3991942/+files/fix-3d-viewer-parsing-segfault-v2.patch
> avoids both crashes. I would be happy if it will be reviewed and applied.

Martin,

Is this your patch?  I am ready to commit it but I need an author to
give credit to the person who wrote this patch.  If it wasn't Martin,
would the submitter of this patch please let me know so I get it
committed ASAP.

Thanks,

Wayne

> 
> It does not fix the rendering problem with what has been parsed (the
> wrl from the second report can be opened in firefox as reference).
> Are there plans to support the complete wrl syntax?
> Or should the 3d-viewer display an error that it encountered some
> models which might not have been parsed correctly and an note how to
> convert those files to simpler, understood, files? (This would save us
> from new reports about incorrect display of 3d models).
> 
> Bye,
> imp
> 
> _______________________________________________
> Mailing list: https://launchpad.net/~kicad-developers
> Post to     : kicad-developers@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~kicad-developers
> More help   : https://help.launchpad.net/ListHelp
>